From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4B1C49ED7 for ; Thu, 19 Sep 2019 08:59:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84ADC21928 for ; Thu, 19 Sep 2019 08:59:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84ADC21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAsHX-0006ka-83 for qemu-devel@archiver.kernel.org; Thu, 19 Sep 2019 04:59:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37454) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAs98-0004rg-Tr for qemu-devel@nongnu.org; Thu, 19 Sep 2019 04:50:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAs97-00051A-MV for qemu-devel@nongnu.org; Thu, 19 Sep 2019 04:50:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35012) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAs92-0004zE-Lg; Thu, 19 Sep 2019 04:50:32 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32046317529C; Thu, 19 Sep 2019 08:50:31 +0000 (UTC) Received: from gondolin (dhcp-192-230.str.redhat.com [10.33.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id AAB9F19C5B; Thu, 19 Sep 2019 08:50:11 +0000 (UTC) Date: Thu, 19 Sep 2019 10:50:08 +0200 From: Cornelia Huck To: Eric Blake Message-ID: <20190919105008.103ede60.cohuck@redhat.com> In-Reply-To: <89d76bbe-8053-e817-2ccb-322bccf1533e@redhat.com> References: <156871562997.196432.17776290406203122029.stgit@bahia.lan> <156871569396.196432.12307975838741351907.stgit@bahia.lan> <20190917132412.6610576c.cohuck@redhat.com> <20190917183620.044e980d@bahia.lan> <20190918122628.7acb9284.cohuck@redhat.com> <89d76bbe-8053-e817-2ccb-322bccf1533e@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 19 Sep 2019 08:50:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Jeff Cody , Mark Cave-Ayland , qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann , Subbaraya Sundeep , qemu-block@nongnu.org, Juan Quintela , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , David Gibson , Eric Farman , Greg Kurz , Yuval Shaia , "Dr. David Alan Gilbert" , Alex Williamson , qemu-arm@nongnu.org, John Snow , Richard Henderson , Kevin Wolf , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 18 Sep 2019 12:46:42 -0500 Eric Blake wrote: > On 9/18/19 5:26 AM, Cornelia Huck wrote: > > On Tue, 17 Sep 2019 18:36:20 +0200 > > Greg Kurz wrote: > > > >> On Tue, 17 Sep 2019 13:24:12 +0200 > >> Cornelia Huck wrote: > >> > >>> On Tue, 17 Sep 2019 12:21:34 +0200 > >>> Greg Kurz wrote: > >>> > >>>> Ensure that hints are added even if errp is &error_fatal or &error_abort. > >>>> > >>>> Signed-off-by: Greg Kurz > >>>> --- > >>>> hw/s390x/s390-ccw.c | 6 ++++-- > >>>> 1 file changed, 4 insertions(+), 2 deletions(-) > >>> > >>> Reviewed-by: Cornelia Huck > >>> > >>> Can also take this via the s390 tree, let me know what would work best. > >> > >> I guess it would be easier to merge if each individual patch goes > >> through the corresponding sub-maintainer tree. But Eric mentioned > >> in another mail that the whole whole series could maybe go through > >> Markus' error tree... so, I don't know which is best. :) > > > > Ok, it's probably best to take this through the s390 tree, as I plan to > > send a pull request tomorrow :) > > If we go with Vladimir's idea of auto-propagation, this change just gets > rewritten again as part of our simplifications to drop all use of > 'local_err' in favor of instead using the macro that makes errp always > safe to use locally. > Fair enough. That auto-propagation approach really looks nice, so I'll go ahead and unqueue this patch again.