* [Qemu-devel] [qemu-web PATCH] Gemfile: use a fixed version of sassc
@ 2019-09-19 13:01 Paolo Bonzini
2019-09-19 15:38 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2019-09-19 13:01 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth
Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the
Gemfile was requiring an earlier version (2.1.0 in practice).
Since the bug has been fixed, remove the workaround and instead
require a fixed version.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Gemfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Gemfile b/Gemfile
index b76a4fd..2117bba 100644
--- a/Gemfile
+++ b/Gemfile
@@ -24,4 +24,4 @@ group :jekyll_plugins do
end
# for https://github.com/sass/sassc-ruby/issues/146
-gem "sassc", "< 2.2.0"
+gem "sassc", ">= 2.2.1"
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [qemu-web PATCH] Gemfile: use a fixed version of sassc
2019-09-19 13:01 [Qemu-devel] [qemu-web PATCH] Gemfile: use a fixed version of sassc Paolo Bonzini
@ 2019-09-19 15:38 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2019-09-19 15:38 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 19/09/2019 15.01, Paolo Bonzini wrote:
> Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the
> Gemfile was requiring an earlier version (2.1.0 in practice).
> Since the bug has been fixed, remove the workaround and instead
> require a fixed version.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Gemfile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Gemfile b/Gemfile
> index b76a4fd..2117bba 100644
> --- a/Gemfile
> +++ b/Gemfile
> @@ -24,4 +24,4 @@ group :jekyll_plugins do
> end
>
> # for https://github.com/sass/sassc-ruby/issues/146
> -gem "sassc", "< 2.2.0"
> +gem "sassc", ">= 2.2.1"
I think you could simply drop the two lines now, "bundle install" will
pick up the newer version anyway.
Both ways work for me, so for any of the two solutions:
Tested-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-19 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-19 13:01 [Qemu-devel] [qemu-web PATCH] Gemfile: use a fixed version of sassc Paolo Bonzini
2019-09-19 15:38 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).