From: Stefano Garzarella <sgarzare@redhat.com>
To: Tao Xu <tao3.xu@intel.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, philmd@redhat.com,
ehabkost@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v2] target/i386: clean up comments over 80 chars per line
Date: Fri, 20 Sep 2019 11:14:56 +0200 [thread overview]
Message-ID: <20190920091456.c6r4lcnsts6jw2v7@steredhat> (raw)
In-Reply-To: <20190920053136.945-1-tao3.xu@intel.com>
On Fri, Sep 20, 2019 at 01:31:36PM +0800, Tao Xu wrote:
> Drop the duplicate definition of CPUID_7_0_ECX_VBMI. And add some
> comments, clean up comments over 80 chars per line.
>
> There is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD,
> remove the extra enter and spaces.
Might it be better to split this patch into two?
One where you fix the comments over 80 chars rand one where you drop the
CPUID_7_0_ECX_VBMI definition.
Thanks,
Stefano
next prev parent reply other threads:[~2019-09-20 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 5:31 [PATCH v2] target/i386: clean up comments over 80 chars per line Tao Xu
2019-09-20 9:14 ` Stefano Garzarella [this message]
2019-09-20 18:29 ` Eduardo Habkost
2019-09-20 18:33 ` Eduardo Habkost
2019-09-23 1:46 ` Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920091456.c6r4lcnsts6jw2v7@steredhat \
--to=sgarzare@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).