qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: [PATCH 7/7] target/alpha: Tidy helper_fp_exc_raise_s
Date: Fri, 20 Sep 2019 21:32:56 -0700	[thread overview]
Message-ID: <20190921043256.4575-8-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190921043256.4575-1-richard.henderson@linaro.org>

Remove a redundant masking of ignore.  Once that's gone it is
obvious that the system-mode inner test is redundant with the
outer test.  Move the fpcr_exc_enable masking up and tidy.

No functional change.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/alpha/fpu_helper.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/target/alpha/fpu_helper.c b/target/alpha/fpu_helper.c
index 62a066d902..df8b58963b 100644
--- a/target/alpha/fpu_helper.c
+++ b/target/alpha/fpu_helper.c
@@ -90,25 +90,18 @@ void helper_fp_exc_raise_s(CPUAlphaState *env, uint32_t ignore, uint32_t regno)
     uint32_t exc = env->error_code & ~ignore;
     if (exc) {
         env->fpcr |= exc;
-        exc &= ~ignore;
-#ifdef CONFIG_USER_ONLY
-        /*
-         * In user mode, the kernel's software handler only
-         * delivers a signal if the exception is enabled.
-         */
-        if (!(exc & env->fpcr_exc_enable)) {
-            return;
-        }
-#else
+        exc &= env->fpcr_exc_enable;
         /*
          * In system mode, the software handler gets invoked
          * for any non-ignored exception.
+         * In user mode, the kernel's software handler only
+         * delivers a signal if the exception is enabled.
          */
+#ifdef CONFIG_USER_ONLY
         if (!exc) {
             return;
         }
 #endif
-        exc &= env->fpcr_exc_enable;
         fp_exc_raise1(env, GETPC(), exc, regno, EXC_M_SWC);
     }
 }
-- 
2.17.1



  parent reply	other threads:[~2019-09-21  4:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-21  4:32 [PATCH 0/7] target/alpha: Fix linux-user exception for CVTTQ Richard Henderson
2019-09-21  4:32 ` [PATCH 1/7] target/alpha: Use array for FPCR_DYN conversion Richard Henderson
2019-09-21  8:53   ` Philippe Mathieu-Daudé
2019-09-23 16:23   ` Alex Bennée
2019-09-21  4:32 ` [PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ Richard Henderson
2019-09-23 16:33   ` Alex Bennée
2019-09-21  4:32 ` [PATCH 3/7] target/alpha: Fix SWCR_TRAP_ENABLE_MASK Richard Henderson
2019-09-21  4:32 ` [PATCH 4/7] target/alpha: Handle SWCR_MAP_DMZ earlier Richard Henderson
2019-09-21  4:32 ` [PATCH 5/7] target/alpha: Write to fpcr_flush_to_zero once Richard Henderson
2019-09-21  8:54   ` Philippe Mathieu-Daudé
2019-09-23 16:38   ` Alex Bennée
2019-09-21  4:32 ` [PATCH 6/7] target/alpha: Mask IOV exception with INV for user-only Richard Henderson
2019-09-23 16:39   ` Alex Bennée
2019-09-21  4:32 ` Richard Henderson [this message]
2019-09-21  8:57   ` [PATCH 7/7] target/alpha: Tidy helper_fp_exc_raise_s Philippe Mathieu-Daudé
2019-09-23 16:40   ` Alex Bennée
2019-09-23 16:44 ` [PATCH 0/7] target/alpha: Fix linux-user exception for CVTTQ Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190921043256.4575-8-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).