From: David Hildenbrand <david@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: [PULL 06/30] s390x/tcg: MVC: Use is_destructive_overlap()
Date: Mon, 23 Sep 2019 10:06:48 +0200 [thread overview]
Message-ID: <20190923080712.23951-7-david@redhat.com> (raw)
In-Reply-To: <20190923080712.23951-1-david@redhat.com>
Let's use the new helper, that also detects destructive overlaps when
wrapping.
We'll make the remaining code (e.g., fast_memmove()) aware of wrapping
later.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
target/s390x/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 013e8d6045..c31cf49593 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -330,7 +330,7 @@ static uint32_t do_helper_mvc(CPUS390XState *env, uint32_t l, uint64_t dest,
*/
if (dest == src + 1) {
fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra);
- } else if (dest < src || src + l <= dest) {
+ } else if (!is_destructive_overlap(env, dest, src, l)) {
fast_memmove(env, dest, src, l, ra);
} else {
for (i = 0; i < l; i++) {
--
2.21.0
next prev parent reply other threads:[~2019-09-23 8:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:06 [PULL 00/30] s390x/tcg update David Hildenbrand
2019-09-23 8:06 ` [PULL 01/30] s390x/tcg: Reset exception_index to -1 instead of 0 David Hildenbrand
2019-09-23 8:06 ` [PULL 02/30] s390x/tcg: MVCL: Zero out unused bits of address David Hildenbrand
2019-09-23 8:06 ` [PULL 03/30] s390x/tcg: MVCL: Detect destructive overlaps David Hildenbrand
2019-09-23 8:06 ` [PULL 04/30] s390x/tcg: MVCL: Process max 4k bytes at a time David Hildenbrand
2019-09-23 8:06 ` [PULL 05/30] s390x/tcg: MVC: Increment the length once David Hildenbrand
2019-09-23 8:06 ` David Hildenbrand [this message]
2019-09-23 8:06 ` [PULL 07/30] s390x/tcg: MVPG: Check for specification exceptions David Hildenbrand
2019-09-23 8:06 ` [PULL 08/30] s390x/tcg: MVPG: Properly wrap the addresses David Hildenbrand
2019-09-23 8:06 ` [PULL 09/30] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time David Hildenbrand
2019-09-23 8:06 ` [PULL 10/30] s390x/tcg: MVCS/MVCP: Check for special operation exceptions David Hildenbrand
2019-09-23 8:06 ` [PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode David Hildenbrand
2019-09-23 8:06 ` [PULL 12/30] s390x/tcg: MVCS/MVCP: Properly wrap the length David Hildenbrand
2019-09-23 8:06 ` [PULL 13/30] s390x/tcg: MVST: Check for specification exceptions David Hildenbrand
2019-09-23 8:06 ` [PULL 14/30] s390x/tcg: MVST: Fix storing back the addresses to registers David Hildenbrand
2019-09-23 8:06 ` [PULL 15/30] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY David Hildenbrand
2019-09-23 8:06 ` [PULL 16/30] s390x/tcg: Fault-safe memset David Hildenbrand
2019-09-23 8:06 ` [PULL 17/30] s390x/tcg: Fault-safe memmove David Hildenbrand
2019-09-23 8:07 ` [PULL 18/30] s390x/tcg: MVCS/MVCP: Use access_memmove() David Hildenbrand
2019-09-23 8:07 ` [PULL 19/30] s390x/tcg: MVC: Fault-safe handling on destructive overlaps David Hildenbrand
2019-09-23 8:07 ` [PULL 20/30] s390x/tcg: MVCLU: Fault-safe handling David Hildenbrand
2019-09-23 8:07 ` [PULL 21/30] s390x/tcg: OC: " David Hildenbrand
2019-09-23 8:07 ` [PULL 22/30] s390x/tcg: XC: " David Hildenbrand
2019-09-23 8:07 ` [PULL 23/30] s390x/tcg: NC: " David Hildenbrand
2019-09-23 8:07 ` [PULL 24/30] s390x/tcg: MVCIN: " David Hildenbrand
2019-09-23 8:07 ` [PULL 25/30] s390x/tcg: MVN: " David Hildenbrand
2019-09-23 8:07 ` [PULL 26/30] s390x/tcg: MVZ: " David Hildenbrand
2019-09-23 8:07 ` [PULL 27/30] s390x/tcg: MVST: " David Hildenbrand
2019-09-23 8:07 ` [PULL 28/30] s390x/tcg: MVO: " David Hildenbrand
2019-09-23 8:07 ` [PULL 29/30] tests/tcg: target/s390x: Test MVO David Hildenbrand
2019-09-23 8:07 ` [PULL 30/30] tests/tcg: target/s390x: Test MVC David Hildenbrand
2019-09-23 13:54 ` [PULL 00/30] s390x/tcg update no-reply
2019-09-23 20:46 ` no-reply
2019-09-23 22:04 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923080712.23951-7-david@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).