From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: thuth@redhat.com, alex.bennee@linaro.org, qemu-devel@nongnu.org,
quintela@redhat.com
Subject: Re: [PATCH 0/2] migration test tweeks
Date: Mon, 23 Sep 2019 14:36:57 +0100 [thread overview]
Message-ID: <20190923133657.GE2822@work-vm> (raw)
In-Reply-To: <20190923132407.GA28074@xz-x1>
* Peter Xu (peterx@redhat.com) wrote:
> On Mon, Sep 23, 2019 at 02:10:20PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Alex noticed that some of the postcopy tests would occasionally
> > hang; this series adds some checks to make them more likely
> > to assert than hang in some failure cases, and changes
> > the migration bandwidth so that under load it's much more likely
> > to manage to land in postcopy.
> >
> > Dr. David Alan Gilbert (2):
> > tests/migration: Fail on unexpected migration states
> > tests/migration/postcopy: trim migration bandwidth
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
>
> I might be even more aggresive on patch 2 when turning down the
> bandwidth. :)
>
> Another thing I thought about on the hang issue is that maybe we can
> give a timeout for the waits and when the timeout triggers before a
> directly assert in the test case we send sigabrt to QEMU (just like
> what kill_qemu does) then we could have a chance to see the cores.
> Not sure whether that could help, though.
Yes I might need to add that; I can see there's another hang somewhere
even with these two patches.
(I *think* it's at the end while it's waiting for completion after
resumption - but I've not figured out what's going on yet).
Dave
> Regards,
>
> --
> Peter Xu
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-09-23 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 13:10 [PATCH 0/2] migration test tweeks Dr. David Alan Gilbert (git)
2019-09-23 13:10 ` [PATCH 1/2] tests/migration: Fail on unexpected migration states Dr. David Alan Gilbert (git)
2019-09-23 14:12 ` Cleber Rosa
2019-09-23 16:20 ` Alex Bennée
2019-09-24 7:24 ` Juan Quintela
2019-09-23 13:10 ` [PATCH 2/2] tests/migration/postcopy: trim migration bandwidth Dr. David Alan Gilbert (git)
2019-09-23 14:14 ` Cleber Rosa
2019-09-23 16:15 ` Alex Bennée
2019-09-24 7:25 ` Juan Quintela
2019-09-23 13:24 ` [PATCH 0/2] migration test tweeks Peter Xu
2019-09-23 13:36 ` Dr. David Alan Gilbert [this message]
2019-09-25 10:35 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923133657.GE2822@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).