From: Cleber Rosa <crosa@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"John Snow" <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/5] docker: move tests from python2 to python3
Date: Mon, 23 Sep 2019 12:10:50 -0400 [thread overview]
Message-ID: <20190923161050.GA29623@dhcp-17-179.bos.redhat.com> (raw)
In-Reply-To: <4ed65a51-051c-0a61-d63c-042306740a7d@redhat.com>
On Sat, Sep 21, 2019 at 10:48:06AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/21/19 12:12 AM, John Snow wrote:
> > As part of the push to drop python2 support, replace any explicit python2
> > dependencies with python3 versions.
> >
> > For centos, python2 still exists as an implicit dependency, but by adding
> > python3 we will be able to build even if the configure script begins to
> > require python 3.5+.
> >
> > Tested with centos7, fedora, ubuntu, ubuntu1804, and debian 9 (amd64).
> > Tested under a custom configure script that requires Python 3.5+.
> >
> > the travis dockerfile is also moved to using python3, which was tested
> > by running `make docker-test-build@travis`, which I hope is sufficient.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> > Message-id: 20190920200049.27216-1-jsnow@redhat.com
> ^ remove
>
> v1 has:
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> > ---
> > tests/docker/dockerfiles/centos7.docker | 2 +-
> > tests/docker/dockerfiles/debian-ports.docker | 2 +-
> > tests/docker/dockerfiles/debian-sid.docker | 2 +-
> > tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 +-
> > tests/docker/dockerfiles/debian10.docker | 2 +-
> > tests/docker/dockerfiles/debian8.docker | 3 +--
>
> If you queue this patch at the end of your series, no need to patch
> debian8.docker.
>
Yep, agreed.
- Cleber.
next prev parent reply other threads:[~2019-09-23 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 22:12 [PATCH v2 0/5] docker: misc cleanups John Snow
2019-09-20 22:12 ` [PATCH v2 1/5] docker: move tests from python2 to python3 John Snow
2019-09-21 8:48 ` Philippe Mathieu-Daudé
2019-09-23 16:10 ` Cleber Rosa [this message]
2019-09-23 16:14 ` Cleber Rosa
2019-09-20 22:12 ` [PATCH v2 2/5] docker: remove 'deprecated' image definitions John Snow
2019-09-20 22:12 ` [PATCH v2 3/5] docker: remove debian8-mxe definitions John Snow
2019-09-21 8:45 ` Philippe Mathieu-Daudé
2019-09-20 22:12 ` [PATCH v2 4/5] docker: remove unused debian-sid and debian-ports John Snow
2019-09-20 22:12 ` [PATCH v2 5/5] docker: removed unused debian8 partial image John Snow
2019-09-21 8:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923161050.GA29623@dhcp-17-179.bos.redhat.com \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).