From: Alex Williamson <alex.williamson@redhat.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, aik@ozlabs.ru,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
qemu-arm@nongnu.org, pbonzini@redhat.com,
david@gibson.dropbear.id.au, eric.auger.pro@gmail.com
Subject: Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle
Date: Mon, 23 Sep 2019 17:10:43 -0600 [thread overview]
Message-ID: <20190923171043.4de13820@x1.home> (raw)
In-Reply-To: <765755f6-4447-9322-d276-567d844ed50c@redhat.com>
On Mon, 23 Sep 2019 13:43:08 +0200
Auger Eric <eric.auger@redhat.com> wrote:
> On 9/23/19 9:51 AM, Peter Xu wrote:
> > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote:
> >> @@ -1308,9 +1319,9 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as,
> >> &address_space_memory);
> >> if (container->error) {
> >> memory_listener_unregister(&container->prereg_listener);
> >> - ret = container->error;
> >> - error_setg(errp,
> >> - "RAM memory listener initialization failed for container");
> >> + ret = -1;
> >> + error_propagate_prepend(errp, container->error,
> >> + "RAM memory listener initialization failed: ");
> >
> > (I saw that we've got plenty of prepended prefixes for an error
> > messages. For me I'll disgard quite a few of them because the errors
> > will directly be delivered to the top level user, but this might be
> > too personal as a comment)
> That's true we have a lot of prefix messages.
>
> The output message now is:
>
> "vfio 0000:89:00.0: failed
> to setup container for group 2: memory listener initialization failed:
> Region smmuv3-iommu-memory-region-0-6: device 01.00.0 requires iommu MAP
> notifier which is not currently supported"
>
> Alex, any opinion?
Peter, I don't really understand what the comment is here. Is it the
number of prepends on the error message? I don't really have an
opinion on that so long as the end message makes sense. Seems like if
we're familiar with the error generation it helps to unwind the
context. Thanks,
Alex
next prev parent reply other threads:[~2019-09-23 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 6:55 [PATCH v3 0/2] Allow memory_region_register_iommu_notifier() to fail Eric Auger
2019-09-23 6:55 ` [PATCH v3 1/2] vfio: Turn the container error into an Error handle Eric Auger
2019-09-23 7:51 ` Peter Xu
2019-09-23 11:43 ` Auger Eric
2019-09-23 23:10 ` Alex Williamson [this message]
2019-09-23 23:49 ` Peter Xu
2019-09-23 23:05 ` Alex Williamson
2019-09-24 9:42 ` Auger Eric
2019-09-23 6:55 ` [PATCH v3 2/2] memory: allow memory_region_register_iommu_notifier() to fail Eric Auger
2019-09-23 7:59 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923171043.4de13820@x1.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).