From: Cleber Rosa <crosa@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] podman: fix command invocation
Date: Mon, 23 Sep 2019 14:46:32 -0400 [thread overview]
Message-ID: <20190923184632.GA6528@dhcp-17-179.bos.redhat.com> (raw)
In-Reply-To: <20190913193821.17756-1-jsnow@redhat.com>
On Fri, Sep 13, 2019 at 03:38:21PM -0400, John Snow wrote:
> Oops; there's no argv here.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 29613afd48..bc7a470ca2 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -334,7 +334,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
> --
> 2.21.0
>
>
Hit it Today while testing your test/docker Python 3 patches.
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
prev parent reply other threads:[~2019-09-23 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 19:38 [Qemu-devel] [PATCH] podman: fix command invocation John Snow
2019-09-13 21:23 ` Alex Bennée
2019-09-23 18:46 ` Cleber Rosa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923184632.GA6528@dhcp-17-179.bos.redhat.com \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).