* [Qemu-devel] [PATCH] podman: fix command invocation
@ 2019-09-13 19:38 John Snow
2019-09-13 21:23 ` Alex Bennée
2019-09-23 18:46 ` Cleber Rosa
0 siblings, 2 replies; 3+ messages in thread
From: John Snow @ 2019-09-13 19:38 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Alex Bennée, John Snow,
Philippe Mathieu-Daudé
Oops; there's no argv here.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/docker/docker.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 29613afd48..bc7a470ca2 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -334,7 +334,7 @@ class Docker(object):
cmd = [ "-u", str(uid) ] + cmd
# podman requires a bit more fiddling
if self._command[0] == "podman":
- argv.insert(0, '--userns=keep-id')
+ cmd.insert(0, '--userns=keep-id')
ret = self._do_check(["run", "--label",
"com.qemu.instance.uuid=" + label] + cmd,
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] podman: fix command invocation
2019-09-13 19:38 [Qemu-devel] [PATCH] podman: fix command invocation John Snow
@ 2019-09-13 21:23 ` Alex Bennée
2019-09-23 18:46 ` Cleber Rosa
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2019-09-13 21:23 UTC (permalink / raw)
To: John Snow; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
John Snow <jsnow@redhat.com> writes:
> Oops; there's no argv here.
Oops indeed. Queued to testing/next, thanks.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 29613afd48..bc7a470ca2 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -334,7 +334,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] podman: fix command invocation
2019-09-13 19:38 [Qemu-devel] [PATCH] podman: fix command invocation John Snow
2019-09-13 21:23 ` Alex Bennée
@ 2019-09-23 18:46 ` Cleber Rosa
1 sibling, 0 replies; 3+ messages in thread
From: Cleber Rosa @ 2019-09-23 18:46 UTC (permalink / raw)
To: John Snow
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée,
qemu-devel
On Fri, Sep 13, 2019 at 03:38:21PM -0400, John Snow wrote:
> Oops; there's no argv here.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 29613afd48..bc7a470ca2 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -334,7 +334,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
> --
> 2.21.0
>
>
Hit it Today while testing your test/docker Python 3 patches.
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-23 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-13 19:38 [Qemu-devel] [PATCH] podman: fix command invocation John Snow
2019-09-13 21:23 ` Alex Bennée
2019-09-23 18:46 ` Cleber Rosa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).