From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3361BC432C1 for ; Tue, 24 Sep 2019 19:56:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04A402146E for ; Tue, 24 Sep 2019 19:56:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04A402146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqv8-0006MY-Op for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 15:56:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqmz-0007Js-4Y for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:47:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCqmy-0006gY-3G for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:47:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41758) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCqmx-0006em-NI for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:47:55 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9B4B8980EF for ; Tue, 24 Sep 2019 18:29:59 +0000 (UTC) Received: from work-vm (ovpn-117-225.ams2.redhat.com [10.36.117.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4333C10013D9; Tue, 24 Sep 2019 18:29:56 +0000 (UTC) Date: Tue, 24 Sep 2019 19:29:53 +0100 From: "Dr. David Alan Gilbert" To: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery Message-ID: <20190924182953.GE2725@work-vm> References: <20190906130103.20961-1-peterx@redhat.com> <87muetblm7.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87muetblm7.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Tue, 24 Sep 2019 18:29:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Xiaohui Li , qemu-devel@nongnu.org, Peter Xu , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Markus Armbruster (armbru@redhat.com) wrote: > migration-tests hangs intermittently for me, and git bisect led me > here. Test script: > > i=0; while true; do let i++; echo "= $i ="; MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/migration-test -p /x86_64/migration/postcopy/recovery -k; done Which is fixed by the patch I posted yesterday: migration/postcopy: Recognise the recovery states as 'in_postcopy' Good working finding it using a bisect - it was way too unreliable for me to find repeatably. The 'Fix postcopy bw for recovery' patch is actually right - it just exposes another existing race. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK