From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDDAC432C1 for ; Tue, 24 Sep 2019 20:11:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7DDF214DA for ; Tue, 24 Sep 2019 20:11:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7DDF214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrA5-0002mP-FC for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 16:11:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43661) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCr85-0000PC-DL for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCr83-0002ox-ML for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:09:45 -0400 Received: from relay.sw.ru ([185.231.240.75]:38020) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCr83-0002np-F4; Tue, 24 Sep 2019 16:09:43 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iCr7r-0001Mk-Gw; Tue, 24 Sep 2019 23:09:31 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v3 00/25] error: auto propagated local_err Date: Tue, 24 Sep 2019 23:08:37 +0300 Message-Id: <20190924200902.4703-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paul Burton , Peter Maydell , Jeff Cody , Jason Wang , Mark Cave-Ayland , Michael Roth , Gerd Hoffmann , Subbaraya Sundeep , qemu-block@nongnu.org, Juan Quintela , Aleksandar Rikalo , "Michael S. Tsirkin" , Markus Armbruster , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , David Gibson , Eric Farman , Eduardo Habkost , Greg Kurz , Yuval Shaia , "Dr. David Alan Gilbert" , Alex Williamson , integration@gluster.org, David Hildenbrand , John Snow , Richard Henderson , Kevin Wolf , vsementsov@virtuozzo.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Cornelia Huck , qemu-s390x@nongnu.org, Max Reitz , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi all! Here is a proposal of auto propagation for local_err, to not call error_propagate on every exit point, when we deal with local_err. There are also two issues with errp: 1. error_fatal & error_append_hint: user can't see these hints, because exit() happens in error_setg earlier than hint is appended. [Reported by Greg Kurz] 2. error_abort & error_propagate: when we wrap error_abort by local_err+error_propagate, resulting coredump will refer to error_propagate and not to the place where error happened. (the macro itself don't fix the issue, but it allows to [3.] drop all local_err+error_propagate pattern, which will definitely fix the issue) [Reported by Kevin Wolf] Still, applying new macro to all errp-functions is a huge task, which is impossible to solve in one series. So, here is a minimum: solve only [1.], by adding new macro to all errp-functions which wants to call error_append_hint. v3: plan B: fix only error_append_hint users, as a first step. 01: - new errp-based API dropped, so now patch is smaller. - slightly adjust commit message - keep Eric's r-b 02: - no new API, so just open-code fix - keep Eric's r-b 03: - simplify the code [Eric] 04: - grammar and wording - drop extra unused variable others: new Vladimir Sementsov-Ogievskiy (25): errp: rename errp to errp_in where it is IN-argument hw/core/loader-fit: fix freeing errp in fit_load_fdt net/net: fix local variable shadowing in net_client_init error: auto propagated local_err scripts: add coccinelle script to fix error_append_hint usage python: add commit-per-subsystem.py s390: Fix error_append_hint usage ARM TCG CPUs: Fix error_append_hint usage PowerPC TCG CPUs: Fix error_append_hint usage arm: Fix error_append_hint usage SmartFusion2: Fix error_append_hint usage PCI: Fix error_append_hint usage SCSI: Fix error_append_hint usage USB: Fix error_append_hint usage VFIO: Fix error_append_hint usage virtio: Fix error_append_hint usage virtio-9p: Fix error_append_hint usage block: Fix error_append_hint usage chardev: Fix error_append_hint usage cmdline: Fix error_append_hint usage QOM: Fix error_append_hint usage Migration: Fix error_append_hint usage Sockets: Fix error_append_hint usage nbd: Fix error_append_hint usage PVRDMA: Fix error_append_hint usage include/monitor/hmp.h | 2 +- include/qapi/error.h | 37 +++++++++- ui/vnc.h | 2 +- block/backup.c | 1 + block/dirty-bitmap.c | 1 + block/file-posix.c | 3 + block/gluster.c | 2 + block/qcow.c | 1 + block/qcow2.c | 1 + block/vhdx-log.c | 1 + block/vpc.c | 1 + chardev/spice.c | 1 + hw/9pfs/9p-local.c | 1 + hw/9pfs/9p-proxy.c | 1 + hw/arm/msf2-soc.c | 1 + hw/arm/virt.c | 2 + hw/core/loader-fit.c | 1 + hw/intc/arm_gicv3_kvm.c | 1 + hw/misc/msf2-sysreg.c | 1 + hw/pci-bridge/pcie_root_port.c | 1 + hw/ppc/mac_newworld.c | 1 + hw/ppc/spapr.c | 1 + hw/ppc/spapr_pci.c | 1 + hw/rdma/vmw/pvrdma_main.c | 1 + hw/s390x/s390-ccw.c | 1 + hw/scsi/scsi-disk.c | 1 + hw/scsi/scsi-generic.c | 1 + hw/usb/ccid-card-emulated.c | 1 + hw/vfio/common.c | 2 + hw/vfio/pci.c | 2 + hw/virtio/virtio-pci.c | 2 + migration/migration.c | 1 + monitor/hmp-cmds.c | 8 +-- nbd/client.c | 1 + nbd/server.c | 1 + net/net.c | 17 ++--- qdev-monitor.c | 2 + target/ppc/kvm.c | 2 + ui/vnc.c | 10 +-- util/error.c | 8 +-- util/qemu-option.c | 2 + util/qemu-sockets.c | 2 + python/commit-per-subsystem.py | 69 +++++++++++++++++++ .../fix-error_append_hint-usage.cocci | 25 +++++++ 44 files changed, 198 insertions(+), 26 deletions(-) create mode 100755 python/commit-per-subsystem.py create mode 100644 scripts/coccinelle/fix-error_append_hint-usage.cocci CC: John Snow CC: Kevin Wolf CC: Max Reitz CC: Fam Zheng CC: Jeff Cody CC: "Marc-André Lureau" CC: Paolo Bonzini CC: Greg Kurz CC: Subbaraya Sundeep CC: Peter Maydell CC: Paul Burton CC: Aleksandar Rikalo CC: "Michael S. Tsirkin" CC: Marcel Apfelbaum CC: Mark Cave-Ayland CC: David Gibson CC: Yuval Shaia CC: Cornelia Huck CC: Eric Farman CC: Richard Henderson CC: David Hildenbrand CC: Halil Pasic CC: Christian Borntraeger CC: Gerd Hoffmann CC: Alex Williamson CC: Markus Armbruster CC: Michael Roth CC: Juan Quintela CC: "Dr. David Alan Gilbert" CC: Eric Blake CC: Jason Wang CC: "Daniel P. Berrangé" CC: Eduardo Habkost CC: qemu-block@nongnu.org CC: qemu-devel@nongnu.org CC: integration@gluster.org CC: qemu-arm@nongnu.org CC: qemu-ppc@nongnu.org CC: qemu-s390x@nongnu.org -- 2.21.0