qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: qemu-ppc@nongnu.org, clg@kaod.org, qemu-devel@nongnu.org
Cc: "Jason Wang" <jasowang@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	groug@kaod.org, "Laurent Vivier" <laurent@vivier.eu>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	philmd@redhat.com, "David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH 07/20] spapr: Fold spapr_phb_lsi_qirq() into its single caller
Date: Wed, 25 Sep 2019 16:45:21 +1000	[thread overview]
Message-ID: <20190925064534.19155-8-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20190925064534.19155-1-david@gibson.dropbear.id.au>

No point having a two-line helper that's used exactly once, and not likely
to be used anywhere else in future.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/spapr_pci.c          | 3 ++-
 include/hw/pci-host/spapr.h | 7 -------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 7b71ad7c74..6934d506a7 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -721,9 +721,10 @@ static void pci_spapr_set_irq(void *opaque, int irq_num, int level)
      * corresponding qemu_irq.
      */
     SpaprPhbState *phb = opaque;
+    SpaprMachineState *spapr = SPAPR_MACHINE(qdev_get_machine());
 
     trace_spapr_pci_lsi_set(phb->dtbusname, irq_num, phb->lsi_table[irq_num].irq);
-    qemu_set_irq(spapr_phb_lsi_qirq(phb, irq_num), level);
+    qemu_set_irq(spapr_qirq(spapr, phb->lsi_table[irq_num].irq), level);
 }
 
 static PCIINTxRoute spapr_route_intx_pin_to_irq(void *opaque, int pin)
diff --git a/include/hw/pci-host/spapr.h b/include/hw/pci-host/spapr.h
index abd87605b2..23506f05d9 100644
--- a/include/hw/pci-host/spapr.h
+++ b/include/hw/pci-host/spapr.h
@@ -128,13 +128,6 @@ struct SpaprPhbState {
 #define SPAPR_PCI_NV2ATSD_WIN_SIZE   (NVGPU_MAX_NUM * NVGPU_MAX_LINKS * \
                                       64 * KiB)
 
-static inline qemu_irq spapr_phb_lsi_qirq(struct SpaprPhbState *phb, int pin)
-{
-    SpaprMachineState *spapr = SPAPR_MACHINE(qdev_get_machine());
-
-    return spapr_qirq(spapr, phb->lsi_table[pin].irq);
-}
-
 int spapr_dt_phb(SpaprPhbState *phb, uint32_t intc_phandle, void *fdt,
                  uint32_t nr_msis, int *node_offset);
 
-- 
2.21.0



  parent reply	other threads:[~2019-09-25  6:50 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25  6:45 [PATCH 00/20] spapr: IRQ subsystem cleanups David Gibson
2019-09-25  6:45 ` [PATCH 01/20] xics: Use incomplete type for XICSFabric David Gibson
2019-09-25  6:55   ` Cédric Le Goater
2019-09-25  7:48     ` Greg Kurz
2019-09-25  7:45   ` Greg Kurz
2019-09-25  6:45 ` [PATCH 02/20] xics: Eliminate 'reject', 'resend' and 'eoi' class hooks David Gibson
2019-09-25  6:45 ` [PATCH 03/20] xics: Rename misleading ics_simple_*() functions David Gibson
2019-09-25  6:45 ` [PATCH 04/20] xics: Eliminate reset hook David Gibson
2019-09-25  7:33   ` Cédric Le Goater
2019-09-25  7:59   ` Greg Kurz
2019-09-26  2:54     ` David Gibson
2019-09-25  6:45 ` [PATCH 05/20] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes David Gibson
2019-09-25  8:16   ` Greg Kurz
2019-09-25  8:31     ` Greg Kurz
2019-09-26  0:55       ` David Gibson
2019-09-26  0:52     ` David Gibson
2019-09-25 12:47   ` Cédric Le Goater
2019-09-25  6:45 ` [PATCH 06/20] xics: Create sPAPR specific ICS subtype David Gibson
2019-09-25  7:34   ` Cédric Le Goater
2019-09-25  8:40   ` Greg Kurz
2019-09-25  8:55     ` Cédric Le Goater
2019-09-25  9:07       ` Greg Kurz
2019-09-26  0:56       ` David Gibson
2019-09-26  7:09         ` Cédric Le Goater
2019-09-27 16:05         ` Greg Kurz
2019-09-30  8:45           ` David Gibson
2019-09-30 17:00             ` Greg Kurz
2019-10-01  1:45               ` David Gibson
2019-09-25  6:45 ` David Gibson [this message]
2019-09-25  6:58   ` [PATCH 07/20] spapr: Fold spapr_phb_lsi_qirq() into its single caller Cédric Le Goater
2019-09-25  8:56   ` Greg Kurz
2019-09-26  7:08   ` Philippe Mathieu-Daudé
2019-09-25  6:45 ` [PATCH 08/20] spapr: Replace spapr_vio_qirq() helper with spapr_vio_irq_pulse() helper David Gibson
2019-09-25  6:58   ` Cédric Le Goater
2019-09-25  8:57   ` Greg Kurz
2019-09-26  7:08   ` Philippe Mathieu-Daudé
2019-09-25  6:45 ` [PATCH 09/20] spapr: Clarify and fix handling of nr_irqs David Gibson
2019-09-25  7:05   ` Cédric Le Goater
2019-09-26  1:03     ` David Gibson
2019-09-26  7:02       ` Cédric Le Goater
2019-09-25 17:13   ` Greg Kurz
2019-09-25  6:45 ` [PATCH 10/20] spapr: Eliminate nr_irqs parameter to SpaprIrq::init David Gibson
2019-09-25  7:06   ` Cédric Le Goater
2019-09-25 17:16   ` Greg Kurz
2019-09-25  6:45 ` [PATCH 11/20] spapr: Fix indexing of XICS irqs David Gibson
2019-09-25  7:11   ` Cédric Le Goater
2019-09-25 20:17   ` Greg Kurz
2019-09-26  1:31     ` David Gibson
2019-09-26  7:21       ` Greg Kurz
2019-09-26 11:32         ` David Gibson
2019-09-26 14:44           ` Greg Kurz
2019-09-25  6:45 ` [PATCH 12/20] spapr: Simplify spapr_qirq() handling David Gibson
2019-09-25  7:16   ` Cédric Le Goater
2019-09-25 20:30   ` Greg Kurz
2019-09-26  7:10   ` Philippe Mathieu-Daudé
2019-09-25  6:45 ` [PATCH 13/20] spapr: Eliminate SpaprIrq:get_nodename method David Gibson
2019-09-25  7:19   ` Cédric Le Goater
2019-09-26  7:11   ` Philippe Mathieu-Daudé
2019-09-26  7:48   ` Greg Kurz
2019-09-26 11:36     ` David Gibson
2019-09-25  6:45 ` [PATCH 14/20] spapr: Remove unhelpful tracepoints from spapr_irq_free_xics() David Gibson
2019-09-25  7:20   ` Cédric Le Goater
2019-09-26  7:11   ` Philippe Mathieu-Daudé
2019-09-26  7:50   ` Greg Kurz
2019-09-25  6:45 ` [PATCH 15/20] spapr: Handle freeing of multiple irqs in frontend only David Gibson
2019-09-25  7:21   ` Cédric Le Goater
2019-09-26  7:52   ` Greg Kurz
2019-09-25  6:45 ` [PATCH 16/20] spapr, xics, xive: Better use of assert()s on irq claim/free paths David Gibson
2019-09-25  7:22   ` Cédric Le Goater
2019-09-26  8:08   ` Greg Kurz
2019-09-26 11:39     ` David Gibson
2019-09-25  6:45 ` [PATCH 17/20] spapr: Remove unused return value in claim path David Gibson
2019-09-25  7:23   ` Cédric Le Goater
2019-09-26  7:13   ` Philippe Mathieu-Daudé
2019-09-26  8:36   ` Greg Kurz
2019-09-27  1:47     ` David Gibson
2019-09-25  6:45 ` [PATCH 18/20] xive: Improve irq claim/free path David Gibson
2019-09-25  7:25   ` Cédric Le Goater
2019-09-26  1:05     ` David Gibson
2019-09-25  6:45 ` [PATCH 19/20] spapr: Use less cryptic representation of which irq backends are supported David Gibson
2019-09-25  7:28   ` Cédric Le Goater
2019-09-26  9:16   ` Greg Kurz
2019-09-25  6:45 ` [PATCH 20/20] spapr: Eliminate SpaprIrq::init hook David Gibson
2019-09-25  7:31   ` Cédric Le Goater
2019-09-26  1:13     ` David Gibson
2019-09-26  7:05       ` Cédric Le Goater
2019-09-26 11:29         ` David Gibson
2019-09-26 15:35         ` Greg Kurz
2019-09-27  5:51           ` David Gibson
2019-09-27  6:23             ` Greg Kurz
2019-09-26 15:39   ` Greg Kurz
2019-09-27 14:12     ` Greg Kurz
2019-09-29  9:34       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190925064534.19155-8-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=clg@kaod.org \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).