From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84ADEC432C2 for ; Wed, 25 Sep 2019 16:21:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58AFD2146E for ; Wed, 25 Sep 2019 16:21:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58AFD2146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDA2t-0005Fb-H0 for qemu-devel@archiver.kernel.org; Wed, 25 Sep 2019 12:21:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42427) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDA1w-00045r-VY for qemu-devel@nongnu.org; Wed, 25 Sep 2019 12:20:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDA1u-00044V-8E for qemu-devel@nongnu.org; Wed, 25 Sep 2019 12:20:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11035) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDA1t-000443-W0 for qemu-devel@nongnu.org; Wed, 25 Sep 2019 12:20:38 -0400 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D0186C059B7C for ; Wed, 25 Sep 2019 16:20:36 +0000 (UTC) Received: by mail-qt1-f197.google.com with SMTP id w9so23650qto.9 for ; Wed, 25 Sep 2019 09:20:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=evU1Bl6pq/idzZG0TpLCRWAK/9K0N8hDGoJHQhixoqs=; b=gzMevA2FEEVohoOVkl/6zofjO9VHxSaIzNSLiCEkqKYZhjBBqZ2FwOv5NuFAdpy/Tg ri/fJl9/qWXCxg+ZtzzWvbvjYU7cfUomdIYfeKE1mWLWAJeboBKrHGS1KkU54645Ju0J 1IVOeIlucwpxFMCdpbipLOcCDA9ypwOKee+FFvi6mFYP4TvXmsfQccx41il4bEWewnRs AXzdwkTumoqhTo7CeuSUnG+36KXaooi15lYtJwBXrw8qBnLU4/a2p2EWK2jzevs3FWcH 741LAkT1Ds5U29AkPHjgxlouQyaQ1WUQxkChhAjAl66GUWeckC0Zulv0GVHE+0H/t4t3 ONbg== X-Gm-Message-State: APjAAAW5QeI7a/0y5qo/fEQHUaIeCWeX13aqZ2aLbgfQ5WF8ZGto3zwm 25REP8fB4Lpf1hB7O16QQoNLD7KPqY98+DYmOaLQ30MJTd/tYAhJAUWiMTEgosDhduJpKreL1K0 N6DLsZl5PzJs6qM0= X-Received: by 2002:a0c:acbb:: with SMTP id m56mr144048qvc.93.1569428436011; Wed, 25 Sep 2019 09:20:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5EvlKvvj5OoVaZnu+2YppW1lEQJ25wvuIz1hMEp5aei2GbXOXEhzzFmPXcWIRI3abQvPhNA== X-Received: by 2002:a0c:acbb:: with SMTP id m56mr144024qvc.93.1569428435728; Wed, 25 Sep 2019 09:20:35 -0700 (PDT) Received: from redhat.com (bzq-79-176-40-226.red.bezeqint.net. [79.176.40.226]) by smtp.gmail.com with ESMTPSA id q126sm3322962qkf.47.2019.09.25.09.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 09:20:34 -0700 (PDT) Date: Wed, 25 Sep 2019 12:20:28 -0400 From: "Michael S. Tsirkin" To: Igor Mammedov Subject: Re: [PATCH-for-4.2 v11 00/11] ARM virt: ACPI memory hotplug support Message-ID: <20190925122006-mutt-send-email-mst@kernel.org> References: <20190918130633.4872-1-shameerali.kolothum.thodi@huawei.com> <20190925112804-mutt-send-email-mst@kernel.org> <20190925173753.7382593d@Igors-MacBook-Pro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925173753.7382593d@Igors-MacBook-Pro> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, sameo@linux.intel.com, shannon.zhaosl@gmail.com, ard.biesheuvel@linaro.org, qemu-devel@nongnu.org, Shameer Kolothum , linuxarm@huawei.com, eric.auger@redhat.com, qemu-arm@nongnu.org, xuwei5@hisilicon.com, sebastien.boeuf@intel.com, lersek@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 25, 2019 at 05:37:53PM +0200, Igor Mammedov wrote: > On Wed, 25 Sep 2019 11:28:42 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 18, 2019 at 02:06:22PM +0100, Shameer Kolothum wrote: > > > This series is an attempt to provide device memory hotplug support > > > on ARM virt platform. This is based on Eric's recent works here[1] > > > and carries some of the pc-dimm related patches dropped from his > > > series. > > > > > > The kernel support for arm64 memory hot add was added recently by > > > Robin and hence the guest kernel should be => 5.0-rc1. > > > > > > NVDIM support is not included currently as we still have an unresolved > > > issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches > > > can be included, but not done for now, for keeping it simple. > > > > > > This makes use of GED device to sent hotplug ACPI events to the > > > Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and > > > Sebastien to add the hardware-reduced support to Nemu using GED > > > device[3]. (Please shout if I got the author/signed-off wrong for > > > those patches or missed any names). > > > > > > This is sanity tested on a HiSilicon ARM64 platform and appreciate > > > any further testing. > > > > > > Note: > > > Attempted adding dimm_pxm test case to bios-tables-test for arm/virt. > > > But noticed the issue decribed here[5]. This is under investigation > > > now. > > > > > > Thanks, > > > Shameer > > > > > > Which tree is this going through? Mine or ARM? > > I'd assume your tree??? > (You are the wizard who knows how to handle bios-tables-test-allowed-diff.h on merge) Sure. Peter if you agree, could you send your ack for that please? > > > > > > > [1] https://patchwork.kernel.org/cover/10837565/ > > > [2] https://patchwork.kernel.org/cover/10783589/ > > > [3] https://github.com/intel/nemu/blob/topic/virt-x86/hw/acpi/ged.c > > > [4] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-May/651763.html > > > [5] https://www.mail-archive.com/qemu-devel@nongnu.org/msg632651.html > > > > > > v10 --> v11 > > > -Changed patch #10 to update bios-tables-test-allowed-diff.h with a > > > list of expected ACPI tables. > > > -GED document changed to rst format (patch #9) > > > -Addressed comments from Igor (patch #3 & #5) > > > -Igor's R-by to #7, #8 & #11. > > > > > > v9 --> v10 > > > -Fix for "make check" failure on x86_64(Patch #1). > > > -Minor updates based on Eric's comments. > > > -Dropped patch "hw/arm/virt: Add 4.2 machine type" as this is already > > > in master now. > > > -Added R-by tags by Eric. > > > > > > v8 --> v9 > > > -Changes related to GED being a TYPE_SYS_BUS_DEVICE now. > > > -Re-arranged patches 8 and 9. > > > -Added GED ABI documentation(patch #10). > > > -Added numamem and memhp tests to arm/virt(#11 and #12) > > > -Dropped few R-by tags as code has changed a bit. > > > -Please see Individual patch history for details. > > > > > > v7 --> v8 > > > -Addressed comments from Igor.Please see individual patches. > > > -Updated bios-tables-test-allowed-diff.h to avoid "make check" > > > failure (patch #6) and dropped patch #10 > > > -Added Igor's R-by to patches 4 & 5. > > > -Dropped Erics's R-by from patch #9 for now. > > > > > > v6 --> v7 > > > - Added 4.2 machine support and restricted GED creation for < 4.2 > > > This is to address the migration test fail reported by Eric. > > > - Included "tests: Update DSDT ACPI table.." patch(#10) from Eric > > > to fix the "make check" bios-tables-test failure. > > > > > > v5 --> v6 > > > > > > -Addressed comments from Eric. > > > -Added R-by from Eric and Igor. > > > > > > v4 --> v5 > > > -Removed gsi/ged-irq routing in virt. > > > -Added Migration support. > > > -Dropped support for DT coldplug case based on the discussions > > > here[4] > > > -Added system_powerdown support through GED. > > > > > > v3 --> v4 > > > Addressed comments from Igor and Eric, > > > -Renamed "virt-acpi" to "acpi-ged". > > > -Changed ged device parent to TYPE_DEVICE. > > > -Introduced DT memory node property "hotpluggable" to resolve device > > > memory being treated as early boot memory issue(patch #7). > > > -Combined patches #3 and #9 from v3 into #3. > > > > > > v2 --> v3 > > > > > > Addressed comments from Igor and Eric, > > > -Made virt acpi device platform independent and moved > > > to hw/acpi/generic_event_device.c > > > -Moved ged specific code into hw/acpi/generic_event_device.c > > > -Introduced an opt-in feature "fdt" to resolve device-memory being > > > treated as early boot memory. > > > -Dropped patch #1 from v2. > > > > > > RFC --> v2 > > > > > > -Use GED device instead of GPIO for ACPI hotplug events. > > > -Removed NVDIMM support for now. > > > -Includes dropped patches from Eric's v9 series. > > > > > > Eric Auger (1): > > > hw/arm/virt: Add memory hotplug framework > > > > > > Samuel Ortiz (2): > > > hw/acpi: Do not create memory hotplug method when handler is not > > > defined > > > hw/acpi: Add ACPI Generic Event Device Support > > > > > > Shameer Kolothum (8): > > > hw/acpi: Make ACPI IO address space configurable > > > hw/arm/virt: Enable device memory cold/hot plug with ACPI boot > > > hw/arm/virt-acpi-build: Add PC-DIMM in SRAT > > > hw/arm: Factor out powerdown notifier from GPIO > > > hw/arm: Use GED for system_powerdown event > > > docs/specs: Add ACPI GED documentation > > > tests: Update ACPI tables list for upcoming arm/virt tests > > > tests: Add bios tests to arm/virt > > > > > > docs/specs/acpi_hw_reduced_hotplug.rst | 70 ++++++ > > > docs/specs/index.rst | 1 + > > > hw/acpi/Kconfig | 4 + > > > hw/acpi/Makefile.objs | 1 + > > > hw/acpi/generic_event_device.c | 311 +++++++++++++++++++++++++ > > > hw/acpi/memory_hotplug.c | 43 ++-- > > > hw/arm/Kconfig | 4 + > > > hw/arm/virt-acpi-build.c | 35 ++- > > > hw/arm/virt.c | 124 +++++++++- > > > hw/i386/acpi-build.c | 7 +- > > > hw/i386/pc.c | 3 + > > > include/hw/acpi/acpi_dev_interface.h | 1 + > > > include/hw/acpi/generic_event_device.h | 103 ++++++++ > > > include/hw/acpi/memory_hotplug.h | 9 +- > > > include/hw/arm/virt.h | 5 + > > > include/hw/i386/pc.h | 3 + > > > tests/bios-tables-test-allowed-diff.h | 16 ++ > > > tests/bios-tables-test.c | 49 ++++ > > > 18 files changed, 748 insertions(+), 41 deletions(-) > > > create mode 100644 docs/specs/acpi_hw_reduced_hotplug.rst > > > create mode 100644 hw/acpi/generic_event_device.c > > > create mode 100644 include/hw/acpi/generic_event_device.h > > > > > > -- > > > 2.17.1 > > >