From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CC5C432C2 for ; Wed, 25 Sep 2019 15:38:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A942121D79 for ; Wed, 25 Sep 2019 15:38:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A942121D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD9NS-00038a-21 for qemu-devel@archiver.kernel.org; Wed, 25 Sep 2019 11:38:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33347) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD9E0-00022Z-BM for qemu-devel@nongnu.org; Wed, 25 Sep 2019 11:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iD9Dz-0000Sf-4m for qemu-devel@nongnu.org; Wed, 25 Sep 2019 11:29:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49262) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iD9Dy-0000SI-VS for qemu-devel@nongnu.org; Wed, 25 Sep 2019 11:29:03 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2EF06757CF for ; Wed, 25 Sep 2019 15:29:02 +0000 (UTC) Received: from work-vm (ovpn-117-251.ams2.redhat.com [10.36.117.251]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09A07608C0; Wed, 25 Sep 2019 15:29:00 +0000 (UTC) Date: Wed, 25 Sep 2019 16:28:58 +0100 From: "Dr. David Alan Gilbert" To: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH v3 0/5] Automatic RCU read unlock Message-ID: <20190925152858.GE2876@work-vm> References: <20190913102538.24167-1-dgilbert@redhat.com> <20190925131324.GG21544@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 25 Sep 2019 15:29:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Paolo Bonzini (pbonzini@redhat.com) wrote: > On 25/09/19 15:13, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> This patch uses glib's g_auto mechanism to automatically free > >> rcu_read_lock's at the end of the block. Given that humans > >> have a habit of forgetting an error path somewhere it's > >> best to leave it to the compiler. > > > > I've had to unqueue this - clang doesn't like the apparently unused > > auto variable; we need to find a way to make that happy. > > __attribute__((unused))? I worry that if I do that, then it'll optimise it out. Dave > Paolo > > > Dave > > > >> v3 > >> Add block-head version of macro > >> Rename > >> Add docs > >> Convert more cases using the block-head version > >> > >> Dr. David Alan Gilbert (5): > >> rcu: Add automatically released rcu_read_lock variants > >> migration: Fix missing rcu_read_unlock > >> migration: Use automatic rcu_read unlock in ram.c > >> migration: Use automatic rcu_read unlock in rdma.c > >> rcu: Use automatic rc_read unlock in core memory/exec code > >> > >> docs/devel/rcu.txt | 16 +++ > >> exec.c | 120 +++++++--------- > >> include/exec/ram_addr.h | 138 +++++++++---------- > >> include/qemu/rcu.h | 25 ++++ > >> memory.c | 15 +- > >> migration/ram.c | 295 +++++++++++++++++++--------------------- > >> migration/rdma.c | 57 ++------ > >> 7 files changed, 310 insertions(+), 356 deletions(-) > >> > >> -- > >> 2.21.0 > >> > >> > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK