From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE6CC4360C for ; Fri, 27 Sep 2019 16:24:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CF9920872 for ; Fri, 27 Sep 2019 16:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I6Dz2Cbq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CF9920872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDt2l-0001DR-O3 for qemu-devel@archiver.kernel.org; Fri, 27 Sep 2019 12:24:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51251) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDrSd-0002UZ-9l for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:43:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDrSa-00089B-Ov for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:43:07 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:42397) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDrSa-000873-9P for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:43:04 -0400 Received: by mail-wr1-x42c.google.com with SMTP id n14so3112337wrw.9 for ; Fri, 27 Sep 2019 07:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=1Vii/oE4Oe++plZNXT8pOaZce8x1F9AjQIS0PE1aPcU=; b=I6Dz2CbqeEu28PPZIr2cgE1cMjhbqcUFC3UoOObAdsK6JEKK2JoMZKCNNGXue3j2Ba p/h4aNcgMBHhyOvJyWW2lYizE56Rw3yhJC8P+S7JTXV2JOfO5nx3XoWuHC4RhCoDZZGY meP8x1fCEs/yAwHFRC9vRMo+BFVv5MjSfcAFPmU689SP2CqGkUyfNdh7IC7BhRE7tUIA iHz2tzRfPOeRrl59gCy8PZUffrYbm42LJ2y2IcBywiaEuuRuLdAuZ/xQ5CaoEh4/Woy9 xsY6mbCBcvPfJsJaR0pbU7KvBT07Np3JIuI/U1Oq+rk6DwJ/V12Tg7Wky6ZbhDCzYLHQ SnAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1Vii/oE4Oe++plZNXT8pOaZce8x1F9AjQIS0PE1aPcU=; b=X5DoAJn7A0cy6ltAYC/a1ETV/BvcQ8ZTnhBik/HLIAUl3exLJUGGcDRkGCi5RnrsIe 94da13Gjs+wvE3sxAWvbYtDgneFTmsK2Z58yMSmEC4Urdil4331H20ivP/dRK2CuncvE v0H8ezPHqMW2SNHGxexO4omnsbhlRW3ZDyoDOhEYIGTWSJj7bkkF6L3qe/m1hU0m0k6Q MPZVLJyuS7G9wfWKQzRn90E0YuVKZjsRA+2rftNpFe0Rh8RkzmTZHJSMF7MskvQ3lvPo dip72eeQOfRwQ2cScjtQbtMJ7wDSlDRbvRj9gKjmBf/ivf6RUwTtcIF7ayCQXJt3Zv8w ZhZQ== X-Gm-Message-State: APjAAAWPtNEhQ/h+feoyUwxZ51qpZ+KRkdXTw3itX7MeDim7yqT6siqP MFDbLZL3rwqZ4mokiMter0rcdlftzdEbug== X-Google-Smtp-Source: APXvYqwhJI60UrD2bC8ap2blNTj2fVqFK4h53f+lmKf9rF8/loZKQi7F+Ugb1fZcSL1/nhomKE/oLA== X-Received: by 2002:adf:ce04:: with SMTP id p4mr3182047wrn.130.1569595375488; Fri, 27 Sep 2019 07:42:55 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id y12sm2874539wrn.74.2019.09.27.07.42.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 07:42:54 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/9] target/arm: handle A-profile semihosting at translate time Date: Fri, 27 Sep 2019 15:42:44 +0100 Message-Id: <20190927144249.29999-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190927144249.29999-1-peter.maydell@linaro.org> References: <20190927144249.29999-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Message-id: 20190913151845.12582-4-alex.bennee@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index b5272119330..698c594e8ce 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10222,14 +10222,25 @@ static bool trans_CBZ(DisasContext *s, arg_CBZ *a) } /* - * Supervisor call + * Supervisor call - both T32 & A32 come here so we need to check + * which mode we are in when checking for semihosting. */ static bool trans_SVC(DisasContext *s, arg_SVC *a) { - gen_set_pc_im(s, s->base.pc_next); - s->svc_imm = a->imm; - s->base.is_jmp = DISAS_SWI; + const uint32_t semihost_imm = s->thumb ? 0xab : 0x123456; + + if (!arm_dc_feature(s, ARM_FEATURE_M) && semihosting_enabled() && +#ifndef CONFIG_USER_ONLY + !IS_USER(s) && +#endif + (a->imm == semihost_imm)) { + gen_exception_internal_insn(s, s->base.pc_next, EXCP_SEMIHOST); + } else { + gen_set_pc_im(s, s->base.pc_next); + s->svc_imm = a->imm; + s->base.is_jmp = DISAS_SWI; + } return true; } -- 2.20.1