From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14623C4360C for ; Sun, 29 Sep 2019 10:08:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB6DF207FA for ; Sun, 29 Sep 2019 10:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="POymn1P1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB6DF207FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEW8O-0004UU-Qn for qemu-devel@archiver.kernel.org; Sun, 29 Sep 2019 06:08:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37361) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEW6t-0003SB-DP for qemu-devel@nongnu.org; Sun, 29 Sep 2019 06:07:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEW6q-0006B9-LG for qemu-devel@nongnu.org; Sun, 29 Sep 2019 06:07:22 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:56361 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iEW6p-000622-QP; Sun, 29 Sep 2019 06:07:20 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46h1RM65yzz9sDB; Sun, 29 Sep 2019 20:07:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569751631; bh=h//Y46NiPXegcnsQmuiMn+YsBahoo6Q2HdTzPbirrY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=POymn1P14HqNg4Rh4yQGrOduw/ADVwQ3DM3ZnCihToEhS0Vf/0RghBTGvtDdBRMea QtqinY3RCRLRxfGj+t/tIjV6XVQyytwo3pMLY/XT6PXxpce6uAg30jHhYhSYF32a4H Ga8eQqS5qvFl8j9DKoygT4j28SUdo+8sLmTlFNos= Date: Sun, 29 Sep 2019 19:34:38 +1000 From: David Gibson To: Greg Kurz Subject: Re: [PATCH 20/20] spapr: Eliminate SpaprIrq::init hook Message-ID: <20190929093438.GD12116@umbus.fritz.box> References: <20190925064534.19155-1-david@gibson.dropbear.id.au> <20190925064534.19155-21-david@gibson.dropbear.id.au> <20190926173937.302ec223@bahia.lan> <20190927161240.69f63705@bahia.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HWvPVVuAAfuRc6SZ" Content-Disposition: inline In-Reply-To: <20190927161240.69f63705@bahia.lan> User-Agent: Mutt/1.12.1 (2019-06-15) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , qemu-devel@nongnu.org, Laurent Vivier , qemu-ppc@nongnu.org, clg@kaod.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --HWvPVVuAAfuRc6SZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 27, 2019 at 04:12:40PM +0200, Greg Kurz wrote: > On Thu, 26 Sep 2019 17:39:37 +0200 > Greg Kurz wrote: >=20 > > On Wed, 25 Sep 2019 16:45:34 +1000 > > David Gibson wrote: > >=20 > > > This method is used to set up the interrupt backends for the current > > > configuration. However, this means some confusing redirection between > > > the "dual" mode init and the init hooks for xics only and xive only m= odes. > > >=20 > > > Since we now have simple flags indicating whether XICS and/or XIVE are > > > supported, it's easier to just open code each initialization directly= in > > > spapr_irq_init(). This will also make some future cleanups simpler. > > >=20 > > > Signed-off-by: David Gibson > > > --- > >=20 > > Reviewed-by: Greg Kurz > >=20 >=20 > Just one nit... >=20 > > > hw/ppc/spapr_irq.c | 138 ++++++++++++++++------------------= -- > > > include/hw/ppc/spapr_irq.h | 1 - > > > include/hw/ppc/xics_spapr.h | 1 + > [...] > > > diff --git a/include/hw/ppc/xics_spapr.h b/include/hw/ppc/xics_spapr.h > > > index 691a6d00f7..267984a97b 100644 > > > --- a/include/hw/ppc/xics_spapr.h > > > +++ b/include/hw/ppc/xics_spapr.h > > > @@ -34,6 +34,7 @@ > > > #define TYPE_ICS_SPAPR "ics-spapr" > > > #define ICS_SPAPR(obj) OBJECT_CHECK(ICSState, (obj), TYPE_ICS_SPAPR) > > > =20 > > > +void ics_spapr_create(SpaprMachineState *spapr, int nr_xirqs, Error = **errp); >=20 > ... this looks like a leftover. Oops, yes, fixed. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --HWvPVVuAAfuRc6SZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl2Qeq4ACgkQbDjKyiDZ s5Lk7xAAuScYt02HVD7fhW1h02qE9ICX4v4Mn/7jbgkv4eFuwZs1f1qwAelojJIE XvNC3naHSTHXiRBe0CVsQhz9gXtLIBmMZqQGNc4FwMOOVDv/COAdmJSBZ+/IzExD SHRxvu4kjuJDrrdrQOCzYbFl2jddzQ/L1loWH6euaO7TlMO1mFSFzUbAK4f5eY5P uZfP915OSEGrWCSFFvsUoCX0pPwbmZyzHuhzAjU2tz2GNU9bKuB7ZL9h8+aPC9Jg AOiH077azb0Ky/SfEA8hCoStbEygPWEUlUwirWP1iF93TzPNF8aVYcWOyaDO+Z+k nT7CogATZY+uCSPZ1NgC6JBWcenul5pWRN9bFZMEIExRqPN4K/3nBv8WcPpDRa1e v5UfuiS5ydA1UhY3t8F70fptPqUPpr2WB5lJBK/B9xEeadDipgcB9y07MNYPpux9 v8RksFcn/eeshSuIeFt/1jUVbfIBD05+0m0iU58tOHSjo1iLpWc+YyCTowAbrzEU DNoE2aJUIS/Xf0uzv48zgPZk43K2eeSth9LPUTmjfCgIOzT+cDYQEyj8MGd0kWER Naw3ga3T71f6VTnKDbsFahMjXAQilrWpIWRmDIvFukUj2p8kZG3pQKP7ZdMtPhXq nuVwPSheZc/myLFlIu/yaS2bLvRJkoWiwwP3S5aRYoOsIWhGiEY= =Whut -----END PGP SIGNATURE----- --HWvPVVuAAfuRc6SZ--