From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45A5C32792 for ; Mon, 30 Sep 2019 15:13:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A911E215EA for ; Mon, 30 Sep 2019 15:13:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A911E215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iExMx-0003mn-MG for qemu-devel@archiver.kernel.org; Mon, 30 Sep 2019 11:13:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59727) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iExLx-00036c-CC for qemu-devel@nongnu.org; Mon, 30 Sep 2019 11:12:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iExLw-0005D3-H9 for qemu-devel@nongnu.org; Mon, 30 Sep 2019 11:12:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38066) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iExLr-0005Bj-J8; Mon, 30 Sep 2019 11:12:39 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB6811918641; Mon, 30 Sep 2019 15:12:36 +0000 (UTC) Received: from linux.fritz.box (ovpn-116-86.ams2.redhat.com [10.36.116.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60ECF6012A; Mon, 30 Sep 2019 15:12:17 +0000 (UTC) Date: Mon, 30 Sep 2019 17:12:15 +0200 From: Kevin Wolf To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v3 04/25] error: auto propagated local_err Message-ID: <20190930151215.GB12777@linux.fritz.box> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> <20190924200902.4703-5-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190924200902.4703-5-vsementsov@virtuozzo.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.70]); Mon, 30 Sep 2019 15:12:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Paul Burton , Jeff Cody , Jason Wang , Mark Cave-Ayland , qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann , Subbaraya Sundeep , qemu-block@nongnu.org, Juan Quintela , Aleksandar Rikalo , "Michael S. Tsirkin" , Markus Armbruster , Halil Pasic , Christian Borntraeger , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , David Gibson , Eric Farman , Eduardo Habkost , Greg Kurz , Yuval Shaia , "Dr. David Alan Gilbert" , Alex Williamson , qemu-arm@nongnu.org, David Hildenbrand , John Snow , Richard Henderson , integration@gluster.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Cornelia Huck , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 24.09.2019 um 22:08 hat Vladimir Sementsov-Ogievskiy geschrieben: > Here is introduced ERRP_FUNCTION_BEGIN macro, to be used at start of > functions with errp parameter. A bit of bike shedding, but FOO_BEGIN suggests to me that a FOO_END will follow. Can we find a different name, especially now that we won't use this macro in every function that uses an errp, so even the "errp function" part isn't really correct any more? How about ERRP_AUTO_PROPAGATE? Kevin