From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382C1C388F3 for ; Tue, 1 Oct 2019 06:49:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1D0E20700 for ; Tue, 1 Oct 2019 06:49:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="lnhdomR/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1D0E20700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFBya-0000Bt-Ux for qemu-devel@archiver.kernel.org; Tue, 01 Oct 2019 02:49:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46561) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFBxe-00084W-En for qemu-devel@nongnu.org; Tue, 01 Oct 2019 02:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFBxc-0005eJ-PJ for qemu-devel@nongnu.org; Tue, 01 Oct 2019 02:48:38 -0400 Received: from ozlabs.org ([203.11.71.1]:58855) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFBxb-0005ci-Un; Tue, 01 Oct 2019 02:48:36 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46j8xC4d19z9sN1; Tue, 1 Oct 2019 16:48:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569912511; bh=ru1/zIE0fHAsRFpY2l+L2H99ijxApXTPRGR9lplFG2I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lnhdomR/fWZ9n48+jIL8/SiItRY0ZygMElfUOC43XfmhUjx9wR1PNg7mfLaJMmGBY GONl/MdU9Rlqs2PEWkLVkg+z3+39eBY4DVsrx6Yp0M870z2lfRj3CT8jo8V6iCF0PV Zrwy4UpkB59Q6hgkpR7PtBd3SFZ8B+3AtLe02P80= Date: Tue, 1 Oct 2019 16:47:26 +1000 From: David Gibson To: =?iso-8859-1?Q?C=E9dric?= Le Goater Subject: Re: [PATCH v2 21/33] spapr, xics, xive: Move cpu_intc_create from SpaprIrq to SpaprInterruptController Message-ID: <20191001064726.GP11105@umbus.fritz.box> References: <20190927055028.11493-1-david@gibson.dropbear.id.au> <20190927055028.11493-22-david@gibson.dropbear.id.au> <20190927121649.5b9f3db7@bahia.lan> <20190930014904.GB11105@umbus.fritz.box> <20190930061445.GG11105@umbus.fritz.box> <75672a0f-6bae-406c-0f0c-d23cc58c9c9f@kaod.org> <20191001023102.GN11105@umbus.fritz.box> <9c6c7e17-0578-2313-4324-a5ca75149762@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8G1nIWD3RY794FAy" Content-Disposition: inline In-Reply-To: <9c6c7e17-0578-2313-4324-a5ca75149762@kaod.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , Greg Kurz , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , philmd@redhat.com, Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --8G1nIWD3RY794FAy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 01, 2019 at 07:43:51AM +0200, C=E9dric Le Goater wrote: > On 01/10/2019 04:31, David Gibson wrote: > > On Mon, Sep 30, 2019 at 12:13:14PM +0200, C=E9dric Le Goater wrote: > >> On 30/09/2019 08:14, David Gibson wrote: > >>> On Mon, Sep 30, 2019 at 07:28:45AM +0200, C=E9dric Le Goater wrote: > >>>> On 30/09/2019 03:49, David Gibson wrote: > >>>>> On Fri, Sep 27, 2019 at 12:16:49PM +0200, Greg Kurz wrote: > >>>>>> On Fri, 27 Sep 2019 15:50:16 +1000 > >>>>>> David Gibson wrote: > >>>>>> > >>>>>>> This method essentially represents code which belongs to the inte= rrupt > >>>>>>> controller, but needs to be called on all possible intcs, rather = than > >>>>>>> just the currently active one. The "dual" version therefore calls > >>>>>>> into the xics and xive versions confusingly. > >>>>>>> > >>>>>>> Handle this more directly, by making it instead a method on the i= ntc > >>>>>>> backend, and always calling it on every backend that exists. > >>>>>>> > >>>>>>> While we're there, streamline the error reporting a bit. > >>>>>>> > >>>>>>> Signed-off-by: David Gibson > >>>>> [snip] > >>>>>>> @@ -525,6 +469,30 @@ static void spapr_irq_check(SpaprMachineStat= e *spapr, Error **errp) > >>>>>>> /* > >>>>>>> * sPAPR IRQ frontend routines for devices > >>>>>>> */ > >>>>>>> +int spapr_irq_cpu_intc_create(SpaprMachineState *spapr, > >>>>>>> + PowerPCCPU *cpu, Error **errp) > >>>>>>> +{ > >>>>>>> + if (spapr->xive) { > >>>>>>> + SpaprInterruptController *intc =3D SPAPR_INTC(spapr->xiv= e); > >>>>>>> + SpaprInterruptControllerClass *sicc =3D SPAPR_INTC_GET_C= LASS(intc); > >>>>>>> + > >>>>>>> + if (sicc->cpu_intc_create(intc, cpu, errp) < 0) { > >>>>>>> + return -1; > >>>>>>> + } > >>>>>>> + } > >>>>>>> + > >>>>>>> + if (spapr->ics) { > >>>>>>> + SpaprInterruptController *intc =3D SPAPR_INTC(spapr->ics= ); > >>>>>>> + SpaprInterruptControllerClass *sicc =3D SPAPR_INTC_GET_C= LASS(intc); > >>>>>>> + > >>>>>>> + if (sicc->cpu_intc_create(intc, cpu, errp) < 0) { > >>>>>>> + return -1; > >>>>>>> + } > >>>>>>> + } > >>>>>>> + > >>>>>> > >>>>>> Instead of these hooks, what about open-coding spapr_xive_cpu_intc= _create() > >>>>>> and xics_spapr_cpu_intc_create() directly here, like you already d= id for the > >>>>>> ICS and the XIVE objects in spapr_irq_init() ? > >>>>> > >>>>> I'd prefer not to. The idea is I want to treat this as basically: > >>>>> > >>>>> foreach_possible_intc(intc) > >>>>> intc::cpu_intc_create(...) > >>>>> > >>>>> If I find time I might indeed replace the explicit ics and xive > >>>>> pointers with just an array of SpaprInterruptController *. > >>>> > >>>> Or you could use object_child_foreach() and check for the type. If w= e had > >>>> a helper object_child_foreach_type(), we could use it elsewhere. > >>> > >>> I thought about that, but I don't think it quite works. The > >>> complication is that the xics device is made explicitly a child of the > >>> machine, but the xive device has mmio, so it's a SusBusDevice sitting > >>> on the root bus instead. > >> > >> PnvXscom works fine with Devices and SysBusDevices. > >=20 > > Uh... what's an example of it working with a SysBusDevice? All the > > implementors of PNV_XSCOM_INTERFACE I could find were instantiated > > with object_initialize_child() making them explicitly children of the > > chip. The SPAPR_XIVE is instantiated with qdev_create(NULL, > > TYPE_SPAPR_XIVE), making it a child of the root bus, not the machine, > > I believe. >=20 > I see. We should reparent the interrupt controller then. Well, maybe. It's not obvious to me that that's the right approach just because of this. > Could we rework=20 > the code to instantiate and realize the XICS and XIVE model objects ?=20 > We have the handlers spapr_instance_init() and spapr_machine_init().=20 I'm not really sure what you're suggesting here. > That always has been a problem IMO. >=20 >=20 > C.=20 > =20 >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8G1nIWD3RY794FAy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl2S9nkACgkQbDjKyiDZ s5J5ZhAAozdd+b4gwoDv/zEiTidvewlJcEM7oyJOdloSqj29Tk2DcWQ578BF2o5y 7pe15gk6SsWptGwH3+IzoHYXB1l7+90c64r3uEX1p0z6f82n3qsN33MmNxuPLvAY 3qRr69QDY4LQpV2gBZnBnaAE/0jCQzN1AYOPuZ5qW7i/+94hr8HIvhjlLGs1O8S/ 0pfvhpNcY+//s3/kWCC4MalLFW9MVhbLAv21Cg7TKknvPQOiG4qlIxQRp9AlEJEo dKx/h9CvnHODS8ujIIf7ESArZligm+fsfF9Kd2MvbU6EE+c/Ru2c1evo6rMrrE8J tZS/5/eBagkRxfQMrS7kbWwfDWFeucBw/rmeutl+V2/TR1gm8iLO9KypKzYolbEq oWslog4Vwy0DT3G7NjOu5DZwFBiLiJEDuE1JKETIwcDel0WAmR6bFZxILSppp1OH 55n/W6rR6gZ4p+nMiB+aXSK7xxkqDMAyRKH+P4fk04U8DDBn4hNIH6Onsr+zhRgO lHODWUECBbevJPDk2RDZ49uE5ykck7U//P5l9KrQMXjCMcF9O5gU8YLHYuwxKxVS QKC56461VkefehzRClBF752TYbVedjbWoc1Ya0aJn9VWouUioOmNhGLnNqq1YL2b U1chAJQEXYCRTS2+MT4ySbQYbvoMjuiVrWc7KC0T7YGVbr7ri78= =jANG -----END PGP SIGNATURE----- --8G1nIWD3RY794FAy--