From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Toe Dev <devtoe82@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: header not included but used in vl.c
Date: Tue, 1 Oct 2019 13:56:10 +0100 [thread overview]
Message-ID: <20191001125610.GN26133@redhat.com> (raw)
In-Reply-To: <CAN+O=TJkZEqHs50gYZgp3n0AeV1h6Wd8UYo+kxss5LUVJqxULQ@mail.gmail.com>
On Tue, Oct 01, 2019 at 03:12:17PM +0300, Toe Dev wrote:
> Hello,
> does it have a reason why the file vl.c lacks reference
> #include "qemu/module.h" ?
> but still uses the defines include their(for example the enum value:
> MODULE_INIT_OPTS)?
qemu/module.h is included by qom/object.h which is included by many
many things in QEMU, so vl.c gets module.h indirectly which is fine.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-10-01 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 12:12 header not included but used in vl.c Toe Dev
2019-10-01 12:56 ` Daniel P. Berrangé [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-01 12:06 Toe Dev
2019-10-09 14:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001125610.GN26133@redhat.com \
--to=berrange@redhat.com \
--cc=devtoe82@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).