qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>, Peter Xu <peterx@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	qemu-s390x <qemu-s390x@nongnu.org>,
	kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Collin Walling <walling@linux.ibm.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PULL 09/12] kvm: clear dirty bitmaps from all overlapping memslots
Date: Wed, 2 Oct 2019 18:01:20 +0200	[thread overview]
Message-ID: <20191002160120.GC5819@localhost.localdomain> (raw)
In-Reply-To: <20190930131955.101131-10-borntraeger@de.ibm.com>

Am 30.09.2019 um 15:19 hat Christian Borntraeger geschrieben:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Currently MemoryRegionSection has 1:1 mapping to KVMSlot.
> However next patch will allow splitting MemoryRegionSection into
> several KVMSlot-s, make sure that kvm_physical_log_slot_clear()
> is able to handle such 1:N mapping.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Message-Id: <20190924144751.24149-3-imammedo@redhat.com>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

This broke the build for me on F29:

  CC      x86_64-softmmu/accel/kvm/kvm-all.o
/tmp/qemu/accel/kvm/kvm-all.c: In function 'kvm_log_clear':
/tmp/qemu/accel/kvm/kvm-all.c:1086:8: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (r < 0) {
        ^
cc1: all warnings being treated as errors

Kevin


  reply	other threads:[~2019-10-02 16:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 13:19 [PULL 00/12] s390x qemu updates 20190930 Christian Borntraeger
2019-09-30 13:19 ` [PULL 01/12] MAINTAINERS: Update S390 PCI Maintainer Christian Borntraeger
2019-09-30 13:19 ` [PULL 02/12] s390: PCI: fix IOMMU region init Christian Borntraeger
2019-09-30 13:19 ` [PULL 03/12] s390x: sclp: refactor invalid command check Christian Borntraeger
2019-09-30 13:19 ` [PULL 04/12] s390x: sclp: boundary check Christian Borntraeger
2019-09-30 13:19 ` [PULL 05/12] s390x: sclp: fix error handling for oversize control blocks Christian Borntraeger
2019-09-30 13:19 ` [PULL 06/12] s390x: sclp: Report insufficient SCCB length Christian Borntraeger
2019-09-30 13:19 ` [PULL 07/12] configure: Remove s390 (31-bit mode) from the list of supported CPUs Christian Borntraeger
2019-09-30 13:19 ` [PULL 08/12] kvm: extract kvm_log_clear_one_slot Christian Borntraeger
2019-09-30 13:19 ` [PULL 09/12] kvm: clear dirty bitmaps from all overlapping memslots Christian Borntraeger
2019-10-02 16:01   ` Kevin Wolf [this message]
2019-10-02 16:13     ` Christian Borntraeger
2019-10-02 16:18       ` Paolo Bonzini
2019-09-30 13:19 ` [PULL 10/12] kvm: split too big memory section on several memslots Christian Borntraeger
2019-09-30 13:19 ` [PULL 11/12] s390: do not call memory_region_allocate_system_memory() multiple times Christian Borntraeger
2019-09-30 13:19 ` [PULL 12/12] s390/kvm: split kvm mem slots at 4TB Christian Borntraeger
2019-10-01 10:40 ` [PULL 00/12] s390x qemu updates 20190930 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002160120.GC5819@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imammedo@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).