From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE46DC352AA for ; Wed, 2 Oct 2019 16:08:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94ADE21D81 for ; Wed, 2 Oct 2019 16:08:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94ADE21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhBE-0001ef-Nf for qemu-devel@archiver.kernel.org; Wed, 02 Oct 2019 12:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56088) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFh4U-0003j0-UQ for qemu-devel@nongnu.org; Wed, 02 Oct 2019 12:01:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFh4P-0002AG-MT for qemu-devel@nongnu.org; Wed, 02 Oct 2019 12:01:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42180) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFh4L-00025J-Qf; Wed, 02 Oct 2019 12:01:39 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D64A610DCCA1; Wed, 2 Oct 2019 16:01:29 +0000 (UTC) Received: from localhost.localdomain (ovpn-117-198.ams2.redhat.com [10.36.117.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97D3A19D70; Wed, 2 Oct 2019 16:01:21 +0000 (UTC) Date: Wed, 2 Oct 2019 18:01:20 +0200 From: Kevin Wolf To: Christian Borntraeger Subject: Re: [PULL 09/12] kvm: clear dirty bitmaps from all overlapping memslots Message-ID: <20191002160120.GC5819@localhost.localdomain> References: <20190930131955.101131-1-borntraeger@de.ibm.com> <20190930131955.101131-10-borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190930131955.101131-10-borntraeger@de.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Wed, 02 Oct 2019 16:01:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Janosch Frank , Matthew Rosato , David Hildenbrand , Cornelia Huck , qemu-devel , Peter Xu , Halil Pasic , qemu-s390x , kvm@vger.kernel.org, Paolo Bonzini , Igor Mammedov , Claudio Imbrenda , Collin Walling , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 30.09.2019 um 15:19 hat Christian Borntraeger geschrieben: > From: Paolo Bonzini > > Currently MemoryRegionSection has 1:1 mapping to KVMSlot. > However next patch will allow splitting MemoryRegionSection into > several KVMSlot-s, make sure that kvm_physical_log_slot_clear() > is able to handle such 1:N mapping. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Igor Mammedov > Reviewed-by: Peter Xu > Message-Id: <20190924144751.24149-3-imammedo@redhat.com> > Acked-by: Paolo Bonzini > Signed-off-by: Christian Borntraeger This broke the build for me on F29: CC x86_64-softmmu/accel/kvm/kvm-all.o /tmp/qemu/accel/kvm/kvm-all.c: In function 'kvm_log_clear': /tmp/qemu/accel/kvm/kvm-all.c:1086:8: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (r < 0) { ^ cc1: all warnings being treated as errors Kevin