From: Matthew Kilgore <mattkilgore12@gmail.com>
To: qemu-devel@nongnu.org
Cc: samuel.thibault@ens-lyon.org,
Matthew Kilgore <mattkilgore12@gmail.com>,
philmd@redhat.com, Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 0/2] curses: fix attribute passing
Date: Thu, 3 Oct 2019 23:53:36 -0400 [thread overview]
Message-ID: <20191004035338.25601-1-mattkilgore12@gmail.com> (raw)
This patch set fixes up ui/curses.c. A previous change to ui/curses.c,
commit 962cf8fd4fae ("ui/curses: manipulate cchar_t with standard curses
functions"), did not correctly pass the attributes from the chtype to
`setcchar()`.
The biggest issue this caused is that colors no longer work when using
the curses display, it instead renders everything in white on black.
This was fixed by correctly passing the color pair number to setcchar().
I also fixed two spots where 0xff was used instead of the bit mask
constants that are part of the curses API.
changes in v2:
- Split into two patches, one dealing with the attribute masks, and one
dealing with correctly passing the color pair number.
Thanks,
Matthew Kilgore
Matthew Kilgore (2):
curses: use the bit mask constants provided by curses
curses: correctly pass the color pair to setcchar()
ui/curses.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-04 3:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 3:53 Matthew Kilgore [this message]
2019-10-04 3:53 ` [PATCH v2 1/2] curses: use the bit mask constants provided by curses Matthew Kilgore
2019-10-04 8:57 ` Philippe Mathieu-Daudé
2019-10-13 15:34 ` Samuel Thibault
2019-10-04 3:53 ` [PATCH v2 2/2] curses: correctly pass the color pair to setcchar() Matthew Kilgore
2019-10-13 15:34 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004035338.25601-1-mattkilgore12@gmail.com \
--to=mattkilgore12@gmail.com \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).