From: Greg Kurz <groug@kaod.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 2/7] spapr, xive: Turn "nr-ends" property into "nr-servers" property
Date: Fri, 4 Oct 2019 08:52:57 +0200 [thread overview]
Message-ID: <20191004085257.53bcfcce@bahia.lan> (raw)
In-Reply-To: <6313a1ea-f891-d7a0-c5f1-ecf656b58bc3@kaod.org>
On Fri, 4 Oct 2019 07:53:13 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> >> @@ -283,11 +292,13 @@ static void spapr_xive_realize(DeviceState *dev, Error **errp)
> >> return;
> >> }
> >>
> >> - if (!xive->nr_ends) {
> >> - error_setg(errp, "Number of interrupt needs to be greater 0");
> >> + if (!xive->nr_servers) {
> >> + error_setg(errp, "Number of interrupt servers must be greater than 0");
> >> return;
> >> }
> >>
> >> + xive->nr_ends = spapr_xive_vcpu_id_to_end_idx(xive->nr_servers);
> >
> > I'd prefer not to store both nr_servers and nr_servers * 8 in the
> > structure. I think you just want xive->nr_servers, then derive it any
> > any places that current look at xive->nr_ends.
>
> Yes I agree. This is a small change.
>
I'm afraid it isn't that simple (see my other mail).
> C.
next prev parent reply other threads:[~2019-10-04 6:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 12:00 [PATCH 0/7] spapr: Use less XIVE HW resources in KVM Greg Kurz
2019-10-03 12:00 ` [PATCH 1/7] spapr, xics: Get number of servers with a XICSFabricClass method Greg Kurz
2019-10-03 12:24 ` Cédric Le Goater
2019-10-03 12:49 ` Greg Kurz
2019-10-03 12:58 ` Cédric Le Goater
2019-10-03 13:02 ` Greg Kurz
2019-10-03 13:19 ` Cédric Le Goater
2019-10-03 13:41 ` Greg Kurz
2019-10-03 13:59 ` Cédric Le Goater
2019-10-03 14:58 ` Greg Kurz
2019-10-03 12:01 ` [PATCH 2/7] spapr, xive: Turn "nr-ends" property into "nr-servers" property Greg Kurz
2019-10-03 12:21 ` Cédric Le Goater
2019-10-03 12:44 ` Greg Kurz
2019-10-04 4:07 ` David Gibson
2019-10-04 5:53 ` Cédric Le Goater
2019-10-04 6:52 ` Greg Kurz [this message]
2019-10-04 7:27 ` Cédric Le Goater
2019-10-04 6:51 ` Greg Kurz
2019-10-05 10:23 ` David Gibson
2019-10-03 12:01 ` [PATCH 3/7] spapr, xics, xive: Drop nr_servers argument in DT-related functions Greg Kurz
2019-10-03 12:25 ` Cédric Le Goater
2019-10-03 12:52 ` Greg Kurz
2019-10-03 12:01 ` [PATCH RFC 4/7] linux-headers: Update against 5.3-rc2 Greg Kurz
2019-10-03 12:01 ` [PATCH 5/7] spapr/xics: Configure number of servers in KVM Greg Kurz
2019-10-03 12:29 ` Cédric Le Goater
2019-10-03 12:55 ` Greg Kurz
2019-10-03 12:01 ` [PATCH 6/7] spapr/xive: " Greg Kurz
2019-10-03 12:30 ` Cédric Le Goater
2019-10-03 12:02 ` [PATCH 7/7] spapr: Set VSMT to smp_threads by default Greg Kurz
2019-10-14 6:12 ` David Gibson
2019-10-14 11:31 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004085257.53bcfcce@bahia.lan \
--to=groug@kaod.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).