From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9785CC47404 for ; Fri, 4 Oct 2019 06:55:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D5BC20862 for ; Fri, 4 Oct 2019 06:55:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D5BC20862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGHUt-0002Nj-E9 for qemu-devel@archiver.kernel.org; Fri, 04 Oct 2019 02:55:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47767) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGHSr-0001VE-R4 for qemu-devel@nongnu.org; Fri, 04 Oct 2019 02:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGHSq-000659-N8 for qemu-devel@nongnu.org; Fri, 04 Oct 2019 02:53:21 -0400 Received: from 7.mo178.mail-out.ovh.net ([46.105.58.91]:46804) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGHSq-00064D-H5 for qemu-devel@nongnu.org; Fri, 04 Oct 2019 02:53:20 -0400 Received: from player730.ha.ovh.net (unknown [10.108.54.209]) by mo178.mail-out.ovh.net (Postfix) with ESMTP id D7E727AF89 for ; Fri, 4 Oct 2019 08:53:17 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player730.ha.ovh.net (Postfix) with ESMTPSA id 6BB00A6EB1E5; Fri, 4 Oct 2019 06:53:13 +0000 (UTC) Date: Fri, 4 Oct 2019 08:52:57 +0200 From: Greg Kurz To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Subject: Re: [PATCH 2/7] spapr, xive: Turn "nr-ends" property into "nr-servers" property Message-ID: <20191004085257.53bcfcce@bahia.lan> In-Reply-To: <6313a1ea-f891-d7a0-c5f1-ecf656b58bc3@kaod.org> References: <157010404888.246126.9768030542733152637.stgit@bahia.lan> <157010406203.246126.13381271918474281392.stgit@bahia.lan> <20191004040725.GB27597@umbus.fritz.box> <6313a1ea-f891-d7a0-c5f1-ecf656b58bc3@kaod.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 17031769365850265995 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrhedtgdegkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.58.91 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 4 Oct 2019 07:53:13 +0200 C=C3=A9dric Le Goater wrote: > >> @@ -283,11 +292,13 @@ static void spapr_xive_realize(DeviceState *dev,= Error **errp) > >> return; > >> } > >> =20 > >> - if (!xive->nr_ends) { > >> - error_setg(errp, "Number of interrupt needs to be greater 0"); > >> + if (!xive->nr_servers) { > >> + error_setg(errp, "Number of interrupt servers must be greater= than 0"); > >> return; > >> } > >> =20 > >> + xive->nr_ends =3D spapr_xive_vcpu_id_to_end_idx(xive->nr_servers); > >=20 > > I'd prefer not to store both nr_servers and nr_servers * 8 in the > > structure. I think you just want xive->nr_servers, then derive it any > > any places that current look at xive->nr_ends. >=20 > Yes I agree. This is a small change. >=20 I'm afraid it isn't that simple (see my other mail). > C.=20