From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] xics: Make some device types not user creatable
Date: Sat, 5 Oct 2019 20:21:33 +1000 [thread overview]
Message-ID: <20191005102133.GE29310@umbus.fritz.box> (raw)
In-Reply-To: <157017826724.337875.14822177178282524024.stgit@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]
On Fri, Oct 04, 2019 at 10:37:47AM +0200, Greg Kurz wrote:
> Some device types of the XICS model are exposed to the QEMU command
> line:
>
> $ ppc64-softmmu/qemu-system-ppc64 -device help | grep ic[sp]
> name "icp"
> name "ics"
> name "ics-spapr"
> name "pnv-icp", desc "PowerNV ICP"
>
> These are internal devices that shouldn't be instantiable by the
> user. By the way, they can't be because their respective realize
> functions expect link properties that can't be set from the command
> line:
>
> qemu-system-ppc64: -device icp: required link 'xics' not found:
> Property '.xics' not found
> qemu-system-ppc64: -device ics: required link 'xics' not found:
> Property '.xics' not found
> qemu-system-ppc64: -device ics-spapr: required link 'xics' not found:
> Property '.xics' not found
> qemu-system-ppc64: -device pnv-icp: required link 'xics' not found:
> Property '.xics' not found
>
> Hide them by setting dc->user_creatable to false in the base class
> "icp" and "ics" init functions.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied to ppc-for-4.2.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-10-06 0:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 8:37 [PATCH] xics: Make some device types not user creatable Greg Kurz
2019-10-05 10:21 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005102133.GE29310@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).