qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-stable@nongnu.org, "Laszlo Ersek" <lersek@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Bruce Rogers" <brogers@suse.com>
Subject: [PULL 2/5] roms/Makefile.edk2: don't pull in submodules when building from tarball
Date: Mon,  7 Oct 2019 15:35:37 +0200	[thread overview]
Message-ID: <20191007133540.30623-3-philmd@redhat.com> (raw)
In-Reply-To: <20191007133540.30623-1-philmd@redhat.com>

From: Michael Roth <mdroth@linux.vnet.ibm.com>

Currently the `make efi` target pulls submodules nested under the
roms/edk2 submodule as dependencies. However, when we attempt to build
from a tarball this fails since we are no longer in a git tree.

A preceding patch will pre-populate these submodules in the tarball,
so assume this build dependency is only needed when building from a
git tree.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Bruce Rogers <brogers@suse.com>
Cc: qemu-stable@nongnu.org # v4.1.0
Reported-by: Bruce Rogers <brogers@suse.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-Id: <20190912231202.12327-3-mdroth@linux.vnet.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 roms/Makefile.edk2 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/roms/Makefile.edk2 b/roms/Makefile.edk2
index c2f2ff59d5..33a074d3a4 100644
--- a/roms/Makefile.edk2
+++ b/roms/Makefile.edk2
@@ -46,8 +46,13 @@ all: $(foreach flashdev,$(flashdevs),../pc-bios/edk2-$(flashdev).fd.bz2) \
 # files.
 .INTERMEDIATE: $(foreach flashdev,$(flashdevs),../pc-bios/edk2-$(flashdev).fd)
 
+# Fetch edk2 submodule's submodules. If it is not in a git tree, assume
+# we're building from a tarball and that they've already been fetched by
+# make-release/tarball scripts.
 submodules:
-	cd edk2 && git submodule update --init --force
+	if test -d edk2/.git; then \
+		cd edk2 && git submodule update --init --force; \
+	fi
 
 # See notes on the ".NOTPARALLEL" target and the "+" indicator in
 # "tests/uefi-test-tools/Makefile".
-- 
2.21.0



  parent reply	other threads:[~2019-10-07 13:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 13:35 [PULL 0/5] edk2-next patches for 2019-10-07 Philippe Mathieu-Daudé
2019-10-07 13:35 ` [PULL 1/5] make-release: pull in edk2 submodules so we can build it from tarballs Philippe Mathieu-Daudé
2019-10-07 13:35 ` Philippe Mathieu-Daudé [this message]
2019-10-07 13:35 ` [PULL 3/5] roms: Add a 'make help' target alias Philippe Mathieu-Daudé
2019-10-07 13:35 ` [PULL 4/5] edk2 build scripts: honor external BaseTools flags with uefi-test-tools Philippe Mathieu-Daudé
2019-10-07 13:35 ` [PULL 5/5] edk2 build scripts: work around TianoCore#1607 without forcing Python 2 Philippe Mathieu-Daudé
2019-10-08 14:08 ` [PULL 0/5] edk2-next patches for 2019-10-07 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007133540.30623-3-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=brogers@suse.com \
    --cc=lersek@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).