From: Andrew Jones <drjones@redhat.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, bijan.mottahedeh@oracle.com, maz@kernel.org
Subject: [RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values
Date: Mon, 7 Oct 2019 19:06:21 +0200 [thread overview]
Message-ID: <20191007170622.1814-5-drjones@redhat.com> (raw)
In-Reply-To: <20191007170622.1814-1-drjones@redhat.com>
If we know what the default value should be then we can test for
that as well as the feature existence.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
tests/arm-cpu-features.c | 44 ++++++++++++++++++++++++++++++++--------
1 file changed, 35 insertions(+), 9 deletions(-)
diff --git a/tests/arm-cpu-features.c b/tests/arm-cpu-features.c
index 92668efb8f56..ee444b04010f 100644
--- a/tests/arm-cpu-features.c
+++ b/tests/arm-cpu-features.c
@@ -141,6 +141,32 @@ static bool resp_get_feature(QDict *resp, const char *feature)
qobject_unref(_resp); \
})
+#define assert_has_feature_enabled(qts, cpu_type, feature) \
+({ \
+ QDict *_resp, *_props; \
+ \
+ _resp = do_query_no_props(qts, cpu_type); \
+ g_assert(_resp); \
+ g_assert(resp_has_props(_resp)); \
+ _props = resp_get_props(_resp); \
+ g_assert(qdict_get(_props, feature)); \
+ g_assert(qdict_get_bool(_props, feature)); \
+ qobject_unref(_resp); \
+})
+
+#define assert_has_feature_disabled(qts, cpu_type, feature) \
+({ \
+ QDict *_resp, *_props; \
+ \
+ _resp = do_query_no_props(qts, cpu_type); \
+ g_assert(_resp); \
+ g_assert(resp_has_props(_resp)); \
+ _props = resp_get_props(_resp); \
+ g_assert(qdict_get(_props, feature)); \
+ g_assert(!qdict_get_bool(_props, feature)); \
+ qobject_unref(_resp); \
+})
+
static void assert_type_full(QTestState *qts)
{
const char *error;
@@ -387,16 +413,16 @@ static void test_query_cpu_model_expansion(const void *data)
assert_error(qts, "host", "The CPU type 'host' requires KVM", NULL);
/* Test expected feature presence/absence for some cpu types */
- assert_has_feature(qts, "max", "pmu");
- assert_has_feature(qts, "cortex-a15", "pmu");
+ assert_has_feature_enabled(qts, "max", "pmu");
+ assert_has_feature_enabled(qts, "cortex-a15", "pmu");
assert_has_not_feature(qts, "cortex-a15", "aarch64");
if (g_str_equal(qtest_get_arch(), "aarch64")) {
- assert_has_feature(qts, "max", "aarch64");
- assert_has_feature(qts, "max", "sve");
- assert_has_feature(qts, "max", "sve128");
- assert_has_feature(qts, "cortex-a57", "pmu");
- assert_has_feature(qts, "cortex-a57", "aarch64");
+ assert_has_feature_enabled(qts, "max", "aarch64");
+ assert_has_feature_enabled(qts, "max", "sve");
+ assert_has_feature_enabled(qts, "max", "sve128");
+ assert_has_feature_enabled(qts, "cortex-a57", "pmu");
+ assert_has_feature_enabled(qts, "cortex-a57", "aarch64");
sve_tests_default(qts, "max");
@@ -417,7 +443,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
qts = qtest_init(MACHINE "-accel kvm -cpu host");
- assert_has_feature(qts, "host", "pmu");
+ assert_has_feature_enabled(qts, "host", "pmu");
if (g_str_equal(qtest_get_arch(), "aarch64")) {
bool kvm_supports_sve;
@@ -427,7 +453,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
QDict *resp;
char *error;
- assert_has_feature(qts, "host", "aarch64");
+ assert_has_feature_enabled(qts, "host", "aarch64");
assert_error(qts, "cortex-a15",
"We cannot guarantee the CPU type 'cortex-a15' works "
--
2.20.1
next prev parent reply other threads:[~2019-10-07 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:06 [RFC PATCH 0/5] target/arm/kvm: Provide an option to adjust virtual time Andrew Jones
2019-10-07 17:06 ` [RFC PATCH 1/5] target/arm/kvm64: kvm64 cpus have timer registers Andrew Jones
2019-10-10 0:45 ` Richard Henderson
2019-10-07 17:06 ` [RFC PATCH 2/5] timer: arm: Introduce functions to get the host cntfrq Andrew Jones
2019-10-10 0:45 ` Richard Henderson
2019-10-07 17:06 ` [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime Andrew Jones
2019-10-10 0:50 ` Richard Henderson
2019-10-10 6:29 ` Andrew Jones
2019-10-07 17:06 ` Andrew Jones [this message]
2019-10-10 0:51 ` [RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values Richard Henderson
2019-10-07 17:06 ` [RFC PATCH 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property Andrew Jones
2019-10-10 0:53 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007170622.1814-5-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=bijan.mottahedeh@oracle.com \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).