From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF569C47404 for ; Mon, 7 Oct 2019 17:04:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9272A206C0 for ; Mon, 7 Oct 2019 17:04:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9272A206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHWQv-0005Cn-LA for qemu-devel@archiver.kernel.org; Mon, 07 Oct 2019 13:04:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36329) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHWOr-00049n-9E for qemu-devel@nongnu.org; Mon, 07 Oct 2019 13:02:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHWOm-0003ZH-BR for qemu-devel@nongnu.org; Mon, 07 Oct 2019 13:02:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52332) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHWOm-0003ZD-5M; Mon, 07 Oct 2019 13:02:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57FD8A44AC2; Mon, 7 Oct 2019 17:02:15 +0000 (UTC) Received: from gondolin (ovpn-116-231.ams2.redhat.com [10.36.116.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2DE4600C1; Mon, 7 Oct 2019 17:02:09 +0000 (UTC) Date: Mon, 7 Oct 2019 19:02:03 +0200 From: Cornelia Huck To: David Hildenbrand Subject: Re: [PATCH v1 0/5] s390x/mmu: Implement more facilities Message-ID: <20191007190203.14714176.cohuck@redhat.com> In-Reply-To: <2cb4d6b8-4058-dca0-95e2-6e8d62741a2c@redhat.com> References: <20190926101627.23376-1-david@redhat.com> <2cb4d6b8-4058-dca0-95e2-6e8d62741a2c@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Mon, 07 Oct 2019 17:02:15 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , qemu-devel@nongnu.org, Ilya Leoshkevich , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 4 Oct 2019 15:23:32 +0200 David Hildenbrand wrote: > On 26.09.19 12:16, David Hildenbrand wrote: > > This is the follow up of: > > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > Without the general MMU rework. It's based on: > > [PATCH v2 0/7] s390x/mmu: DAT translation rewrite > > > > This series adds adds EDAT2 MMU support, and implements/indicates related > > facilities (ESOP-1, ESOP-2, IEP, ...) for TCG. The QEMU CPU model is > > updated. > > > > IEP under QEMU TCG seems to work just fine, when eabling it via the "max" > > CPU model - via kvm unit tests: > > t460s: ~/git/kvm-unit-tests master $ ./s390x-run s390x/iep.elf -cpu max > > [...] > > PASS: iep: iep protection: Program interrupt: expected(4) == received(4) > > SUMMARY: 1 tests > > > > EXIT: STATUS=1 > > > > Changes since "[PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions": > > - "s390x/mmu: Add EDAT2 translation support" > > -- Fix vaddr offset within 2GB page > > - "s390x/mmu: Implement ESOP-2 and ..." > > -- Squashed two patches as requested. > > -- Also set ilen to "2" in case of MMU_INST_FETCH on mmu_translate_real > > - "s390x/mmu: Implement Instruction-Execution-Protection Facility" > > -- Make sure s390_cpu_get_phys_page_debug() doesn't choke on IEP > > - "s390x/cpumodel: Add new TCG features to QEMU cpu model" > > -- Add comment "features introduced after the z13" > > > > Cc: Ilya Leoshkevich > > > > David Hildenbrand (5): > > s390x/mmu: Add EDAT2 translation support > > s390x/mmu: Implement ESOP-2 and > > access-exception-fetch/store-indication facility > > s390x/mmu: Implement Instruction-Execution-Protection Facility > > s390x/cpumodel: Prepare for changes of QEMU model > > s390x/cpumodel: Add new TCG features to QEMU cpu model > > > > hw/s390x/s390-virtio-ccw.c | 2 ++ > > target/s390x/cpu.h | 1 + > > target/s390x/gen-features.c | 11 +++++++++- > > target/s390x/helper.c | 6 +++++- > > target/s390x/mmu_helper.c | 42 +++++++++++++++++++++++++++++++++++-- > > 5 files changed, 58 insertions(+), 4 deletions(-) > > > > @Christian (@Conny) if I can get an ACK on the last patch, I can send > this directly upstream. > No objections from my side, I won't get around to reviewing it in detail anyway.