From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6159C10F14 for ; Tue, 8 Oct 2019 17:49:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A11BB217D7 for ; Tue, 8 Oct 2019 17:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A11BB217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHtcI-0001MD-RA for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 13:49:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51814) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHtRR-0000nO-4h for qemu-devel@nongnu.org; Tue, 08 Oct 2019 13:38:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHtRP-0007Aq-85 for qemu-devel@nongnu.org; Tue, 08 Oct 2019 13:38:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHtRP-0007AZ-2D for qemu-devel@nongnu.org; Tue, 08 Oct 2019 13:38:31 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1002B2026F; Tue, 8 Oct 2019 17:38:30 +0000 (UTC) Received: from work-vm (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC1BD600CE; Tue, 8 Oct 2019 17:38:27 +0000 (UTC) Date: Tue, 8 Oct 2019 18:38:25 +0100 From: "Dr. David Alan Gilbert" To: Wei Yang Subject: Re: [PATCH 1/4] migration/ram: only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE Message-ID: <20191008173825.GI3441@work-vm> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> <20191005220517.24029-2-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191005220517.24029-2-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 08 Oct 2019 17:38:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Wei Yang (richardw.yang@linux.intel.com) wrote: > The only possible bit set in invalid_flags is > RAM_SAVE_FLAG_COMPRESS_PAGE at the beginning of function > ram_load_precopy(), which means it is not necessary to do > another check for RAM_SAVE_FLAG_COMPRESS_PAGE bit. > > Signed-off-by: Wei Yang > --- > migration/ram.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 31051935c8..769d3f6454 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -4263,10 +4263,7 @@ static int ram_load_precopy(QEMUFile *f) > addr &= TARGET_PAGE_MASK; > > if (flags & invalid_flags) { > - if (flags & invalid_flags & RAM_SAVE_FLAG_COMPRESS_PAGE) { > - error_report("Received an unexpected compressed page"); > - } > - > + error_report("Received an unexpected compressed page"); > ret = -EINVAL; I'd rather keep this one; I think Juan's idea is that we might make other flags illegal here and then it's easy to add to invalid_flags at the top. Dave > break; > } > -- > 2.17.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK