From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1DCC4360C for ; Wed, 9 Oct 2019 01:12:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31D38206C2 for ; Wed, 9 Oct 2019 01:12:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31D38206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI0XC-0004NO-Ce for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 21:12:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40345) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI0WB-0003ap-6R for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:11:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI0WA-0002xa-3K for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:11:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:31753) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iI0W9-0002x4-QO for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:11:54 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 18:11:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,273,1566889200"; d="scan'208";a="277276255" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga001.jf.intel.com with ESMTP; 08 Oct 2019 18:11:51 -0700 Date: Wed, 9 Oct 2019 09:11:34 +0800 From: Wei Yang To: "Dr. David Alan Gilbert" Subject: Re: [PATCH 1/4] migration/ram: only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE Message-ID: <20191009011134.GE26203@richard> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> <20191005220517.24029-2-richardw.yang@linux.intel.com> <20191008173825.GI3441@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008173825.GI3441@work-vm> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: qemu-devel@nongnu.org, Wei Yang , quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 08, 2019 at 06:38:25PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> The only possible bit set in invalid_flags is >> RAM_SAVE_FLAG_COMPRESS_PAGE at the beginning of function >> ram_load_precopy(), which means it is not necessary to do >> another check for RAM_SAVE_FLAG_COMPRESS_PAGE bit. >> >> Signed-off-by: Wei Yang >> --- >> migration/ram.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/migration/ram.c b/migration/ram.c >> index 31051935c8..769d3f6454 100644 >> --- a/migration/ram.c >> +++ b/migration/ram.c >> @@ -4263,10 +4263,7 @@ static int ram_load_precopy(QEMUFile *f) >> addr &= TARGET_PAGE_MASK; >> >> if (flags & invalid_flags) { >> - if (flags & invalid_flags & RAM_SAVE_FLAG_COMPRESS_PAGE) { >> - error_report("Received an unexpected compressed page"); >> - } >> - >> + error_report("Received an unexpected compressed page"); >> ret = -EINVAL; > >I'd rather keep this one; I think Juan's idea is that we might make >other flags illegal here and then it's easy to add to invalid_flags at >the top. > Reasonable. >Dave >> break; >> } >> -- >> 2.17.1 >> >-- >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Wei Yang Help you, Help me