From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF349ECE58D for ; Wed, 9 Oct 2019 15:54:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93EDA206BB for ; Wed, 9 Oct 2019 15:54:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93EDA206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIEIS-0001Xh-3V for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 11:54:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42419) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI15x-0008Eh-2q for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:48:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI15v-0007j9-1F for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:48:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36484) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iI15q-0007fD-IG; Tue, 08 Oct 2019 21:48:46 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D68818C892C; Wed, 9 Oct 2019 01:48:45 +0000 (UTC) Received: from localhost.localdomain (ovpn-122-151.rdu2.redhat.com [10.10.122.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8582160C05; Wed, 9 Oct 2019 01:48:38 +0000 (UTC) Date: Tue, 8 Oct 2019 21:48:36 -0400 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 03/19] hw/arm/bcm2835_peripherals: Name various address spaces Message-ID: <20191009014836.GB22824@localhost.localdomain> References: <20190926173428.10713-1-f4bug@amsat.org> <20190926173428.10713-4-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190926173428.10713-4-f4bug@amsat.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.70]); Wed, 09 Oct 2019 01:48:45 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?iso-8859-1?Q?Zolt=E1n?= Baldaszti , Laurent Bonnans , Alistair Francis , qemu-devel@nongnu.org, Andrew Baumann , Esteban Bosse , qemu-arm@nongnu.org, Clement Deschamps , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Cheng Xiang , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Pekka Enberg , Guenter Roeck , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 26, 2019 at 07:34:11PM +0200, Philippe Mathieu-Daud=E9 wrote: > Various address spaces from the BCM2835 are reported as > 'anonymous' in memory tree: >=20 > (qemu) info mtree >=20 > address-space: anonymous > 0000000000000000-000000000000008f (prio 0, i/o): bcm2835-mbox > 0000000000000010-000000000000001f (prio 0, i/o): bcm2835-fb > 0000000000000080-000000000000008f (prio 0, i/o): bcm2835-property >=20 > address-space: anonymous > 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu > 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-pe= ripherals @bcm2835-peripherals 0000000000000000-0000000000ffffff > 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff >=20 > [...] >=20 > Since the address_space_init() function takes a 'name' argument, > set it to correctly describe each address space: >=20 > (qemu) info mtree >=20 > address-space: bcm2835-mbox-memory > 0000000000000000-000000000000008f (prio 0, i/o): bcm2835-mbox > 0000000000000010-000000000000001f (prio 0, i/o): bcm2835-fb > 0000000000000080-000000000000008f (prio 0, i/o): bcm2835-property >=20 > address-space: bcm2835-fb-memory > 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu > 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-pe= ripherals @bcm2835-peripherals 0000000000000000-0000000000ffffff > 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff >=20 > address-space: bcm2835-property-memory > 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu > 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-pe= ripherals @bcm2835-peripherals 0000000000000000-0000000000ffffff > 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff >=20 > address-space: bcm2835-dma-memory > 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu > 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-pe= ripherals @bcm2835-peripherals 0000000000000000-0000000000ffffff > 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff > 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gp= u-ram-alias[*] @ram 0000000000000000-000000003fffffff >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > hw/display/bcm2835_fb.c | 2 +- > hw/dma/bcm2835_dma.c | 2 +- > hw/misc/bcm2835_mbox.c | 2 +- > hw/misc/bcm2835_property.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c > index 8f856878cd..85aaa54330 100644 > --- a/hw/display/bcm2835_fb.c > +++ b/hw/display/bcm2835_fb.c > @@ -425,7 +425,7 @@ static void bcm2835_fb_realize(DeviceState *dev, Er= ror **errp) > s->initial_config.base =3D s->vcram_base + BCM2835_FB_OFFSET; > =20 > s->dma_mr =3D MEMORY_REGION(obj); > - address_space_init(&s->dma_as, s->dma_mr, NULL); > + address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_FB "-memory= "); > =20 > bcm2835_fb_reset(dev); > =20 > diff --git a/hw/dma/bcm2835_dma.c b/hw/dma/bcm2835_dma.c > index 6acc2b644e..1e458d7fba 100644 > --- a/hw/dma/bcm2835_dma.c > +++ b/hw/dma/bcm2835_dma.c > @@ -383,7 +383,7 @@ static void bcm2835_dma_realize(DeviceState *dev, E= rror **errp) > } > =20 > s->dma_mr =3D MEMORY_REGION(obj); > - address_space_init(&s->dma_as, s->dma_mr, NULL); > + address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_DMA "-memor= y"); > =20 > bcm2835_dma_reset(dev); > } > diff --git a/hw/misc/bcm2835_mbox.c b/hw/misc/bcm2835_mbox.c > index 7690b9afaf..77285624c9 100644 > --- a/hw/misc/bcm2835_mbox.c > +++ b/hw/misc/bcm2835_mbox.c > @@ -311,7 +311,7 @@ static void bcm2835_mbox_realize(DeviceState *dev, = Error **errp) > } > =20 > s->mbox_mr =3D MEMORY_REGION(obj); > - address_space_init(&s->mbox_as, s->mbox_mr, NULL); > + address_space_init(&s->mbox_as, s->mbox_mr, TYPE_BCM2835_MBOX "-me= mory"); > bcm2835_mbox_reset(dev); > } > =20 > diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c > index 0a1a3eb5d9..43a5465c5d 100644 > --- a/hw/misc/bcm2835_property.c > +++ b/hw/misc/bcm2835_property.c > @@ -407,7 +407,7 @@ static void bcm2835_property_realize(DeviceState *d= ev, Error **errp) > } > =20 > s->dma_mr =3D MEMORY_REGION(obj); > - address_space_init(&s->dma_as, s->dma_mr, NULL); > + address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_PROPERTY "-= memory"); > =20 > /* TODO: connect to MAC address of USB NIC device, once we emulate= it */ > qemu_macaddr_default_if_unset(&s->macaddr); > --=20 > 2.20.1 >=20 The names you're giving are much more detailed than most other examples I found for address_space_init(), and I like that approach a lot. Reviewed-by: Cleber Rosa