From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
den@openvz.org
Subject: [PATCH v9 0/3] NBD reconnect
Date: Wed, 9 Oct 2019 11:41:55 +0300 [thread overview]
Message-ID: <20191009084158.15614-1-vsementsov@virtuozzo.com> (raw)
Hi all!
Here is NBD reconnect. Previously, if connection failed all current
and future requests will fail. After the series, nbd-client driver
will try to reconnect unlimited times. During first @reconnect-delay
seconds of reconnecting all requests will wait for the connection,
and if it is established requests will be resent. After
@reconnect-delay period all requests will be failed (until successful
reconnect).
v10:
01: add Eric's r-b
02: drop dead assignment local_err = NULL
s/nbd_reconnect_loop/nbd_co_reconnect_loop/
03: avoid race conditions + some improvements
- introduce qemu_io_silent_check and use it to wait for NBD server
start
- use size variable instead of '5M' in all places
- use smart waiting loop instead of sleep, to wait for job progress
- do srv.wait() after srv.kill(), to be sure that server is stopped
- drop throttling earlier
- drop 'quick' tag in group file
Vladimir Sementsov-Ogievskiy (3):
qemu-coroutine-sleep: introduce qemu_co_sleep_wake
block/nbd: nbd reconnect
iotests: test nbd reconnect
include/qemu/coroutine.h | 23 ++-
block/nbd.c | 331 +++++++++++++++++++++++++++-------
util/qemu-coroutine-sleep.c | 51 ++++--
tests/qemu-iotests/264 | 95 ++++++++++
tests/qemu-iotests/264.out | 13 ++
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iotests.py | 11 ++
7 files changed, 447 insertions(+), 78 deletions(-)
create mode 100755 tests/qemu-iotests/264
create mode 100644 tests/qemu-iotests/264.out
--
2.21.0
next reply other threads:[~2019-10-09 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:41 Vladimir Sementsov-Ogievskiy [this message]
2019-10-09 8:41 ` [PATCH v10 1/3] qemu-coroutine-sleep: introduce qemu_co_sleep_wake Vladimir Sementsov-Ogievskiy
2019-10-09 8:41 ` [PATCH v10 2/3] block/nbd: nbd reconnect Vladimir Sementsov-Ogievskiy
2019-10-16 22:39 ` Eric Blake
2019-10-09 8:41 ` [PATCH v10 3/3] iotests: test " Vladimir Sementsov-Ogievskiy
2019-10-23 1:31 ` Eric Blake
2019-10-23 8:33 ` Vladimir Sementsov-Ogievskiy
2019-10-23 11:33 ` Eric Blake
2019-10-09 15:35 ` [PATCH v9 0/3] NBD reconnect Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009084158.15614-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).