From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2149AC47404 for ; Wed, 9 Oct 2019 19:29:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E797D206B6 for ; Wed, 9 Oct 2019 19:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E797D206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIHeW-0005OK-9p for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 15:29:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44885) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIEIy-0002vB-8Q for qemu-devel@nongnu.org; Wed, 09 Oct 2019 11:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIEIx-0005U1-06 for qemu-devel@nongnu.org; Wed, 09 Oct 2019 11:55:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60024) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIEIt-0005RR-81; Wed, 09 Oct 2019 11:55:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D2F3B3086E2F; Wed, 9 Oct 2019 15:55:05 +0000 (UTC) Received: from localhost.localdomain (ovpn-122-151.rdu2.redhat.com [10.10.122.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E94DD5D9E2; Wed, 9 Oct 2019 15:54:52 +0000 (UTC) Date: Wed, 9 Oct 2019 11:54:51 -0400 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 17/19] tests/boot_linux_console: Test the raspi2 UART1 (16550 based) Message-ID: <20191009155451.GD30349@localhost.localdomain> References: <20190926173428.10713-1-f4bug@amsat.org> <20190926173428.10713-18-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190926173428.10713-18-f4bug@amsat.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 09 Oct 2019 15:55:06 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?iso-8859-1?Q?Zolt=E1n?= Baldaszti , Laurent Bonnans , Alistair Francis , qemu-devel@nongnu.org, Andrew Baumann , Esteban Bosse , qemu-arm@nongnu.org, Clement Deschamps , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Cheng Xiang , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Pekka Enberg , Guenter Roeck , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 26, 2019 at 07:34:25PM +0200, Philippe Mathieu-Daud=E9 wrote: > The current do_test_arm_raspi2() case tests the PL011 UART0. > Our model also supports the AUX UART (16550 based). > We can very simply test the UART1 with Linux, modifying the > kernel command line. >=20 > Add few lines to expand our previous test and cover the AUX > UART. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > tests/acceptance/boot_linux_console.py | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/= boot_linux_console.py > index 7eaf6cb60e..33e8f6c635 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -326,6 +326,7 @@ class BootLinuxConsole(Test): > """ > serial_kernel_cmdline =3D { > 0: 'earlycon=3Dpl011,0x3f201000 console=3DttyAMA0', > + 1: 'earlycon=3Duart8250,mmio32,0x3f215040 console=3DttyS1,= 115200' > } > deb_url =3D ('http://archive.raspberrypi.org/debian/' > 'pool/main/r/raspberrypi-firmware/' > @@ -336,7 +337,7 @@ class BootLinuxConsole(Test): > dtb_path =3D self.extract_from_deb(deb_path, '/boot/bcm2709-rp= i-2-b.dtb') > =20 > self.vm.set_machine('raspi2') > - self.vm.set_console() > + self.vm.set_console(console_id=3Duart_id) > kernel_command_line =3D (self.KERNEL_COMMON_COMMAND_LINE + > serial_kernel_cmdline[uart_id]) > self.vm.add_args('-kernel', kernel_path, > @@ -354,6 +355,14 @@ class BootLinuxConsole(Test): > """ > self.do_test_arm_raspi2(0) > =20 > + def test_arm_raspi2_uart1(self): > + """ > + :avocado: tags=3Darch:arm > + :avocado: tags=3Dmachine:raspi2 > + :avocado: tags=3Ddevice:bcm2835_aux > + """ > + self.do_test_arm_raspi2(1) > + > def test_s390x_s390_ccw_virtio(self): > """ > :avocado: tags=3Darch:s390x > --=20 > 2.20.1 >=20 Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa