From: Cleber Rosa <crosa@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH 0/4] iotests: trivial cleanups
Date: Wed, 9 Oct 2019 12:27:40 -0400 [thread overview]
Message-ID: <20191009162740.GH30349@localhost.localdomain> (raw)
In-Reply-To: <ac7839be-eea2-6fa7-eff5-146d2aedf059@redhat.com>
On Mon, Oct 07, 2019 at 03:09:25PM +0200, Max Reitz wrote:
> On 27.09.19 16:17, Cleber Rosa wrote:
> > The most trivial set of cleanups to iotests common libraries and the
> > 044 test.
> >
> > Cleber Rosa (4):
> > qemu-iotests: remove bash shebang from library files
> > qemu-iotests: remove forceful execution success from library files
> > qemu-iotests: 044: pass is actually a noop, so remove it
> > qemu-iotests: 044: remove inaccurate docstring class description
> >
> > tests/qemu-iotests/044 | 4 ----
> > tests/qemu-iotests/common.config | 5 -----
> > tests/qemu-iotests/common.filter | 5 -----
> > tests/qemu-iotests/common.nbd | 1 -
> > tests/qemu-iotests/common.pattern | 2 --
> > tests/qemu-iotests/common.qemu | 2 --
> > tests/qemu-iotests/common.rc | 5 -----
> > tests/qemu-iotests/common.tls | 2 --
> > 8 files changed, 26 deletions(-)
>
> Looks OK to me, but I’d like to know what you think about Eric’s concern
> on patch 1.
>
> Max
>
Yep, I agree with Eric's point. Will send a v2 shortly.
Thanks,
- Cleber.
prev parent reply other threads:[~2019-10-09 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 14:17 [PATCH 0/4] iotests: trivial cleanups Cleber Rosa
2019-09-27 14:17 ` [PATCH 1/4] qemu-iotests: remove bash shebang from library files Cleber Rosa
2019-09-27 16:37 ` Eric Blake
2019-10-09 16:26 ` Cleber Rosa
2019-10-09 18:38 ` Cleber Rosa
2019-09-27 14:17 ` [PATCH 2/4] qemu-iotests: remove forceful execution success " Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 14:17 ` [PATCH 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 20:37 ` John Snow
2019-09-27 14:17 ` [PATCH 4/4] qemu-iotests: 044: remove inaccurate docstring class description Cleber Rosa
2019-09-27 16:48 ` Eric Blake
2019-09-27 20:38 ` John Snow
2019-10-07 13:09 ` [PATCH 0/4] iotests: trivial cleanups Max Reitz
2019-10-09 16:27 ` Cleber Rosa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009162740.GH30349@localhost.localdomain \
--to=crosa@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).