From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B892C47404 for ; Wed, 9 Oct 2019 20:41:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01C5B20B7C for ; Wed, 9 Oct 2019 20:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01C5B20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIIlh-0000I9-NU for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 16:41:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44755) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIGrN-0002Pt-2l for qemu-devel@nongnu.org; Wed, 09 Oct 2019 14:38:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIGrL-0004Nh-W8 for qemu-devel@nongnu.org; Wed, 09 Oct 2019 14:38:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45084) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIGrH-0004Kh-QP; Wed, 09 Oct 2019 14:38:47 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD2593082B13; Wed, 9 Oct 2019 18:38:45 +0000 (UTC) Received: from localhost.localdomain (ovpn-122-151.rdu2.redhat.com [10.10.122.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3FD35D9E2; Wed, 9 Oct 2019 18:38:44 +0000 (UTC) Date: Wed, 9 Oct 2019 14:38:43 -0400 From: Cleber Rosa To: Eric Blake Subject: Re: [PATCH 1/4] qemu-iotests: remove bash shebang from library files Message-ID: <20191009183843.GA9917@localhost.localdomain> References: <20190927141728.7137-1-crosa@redhat.com> <20190927141728.7137-2-crosa@redhat.com> <7ce7f9b7-a79e-21c5-18e2-f7f2ec85e575@redhat.com> <20191009162623.GG30349@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009162623.GG30349@localhost.localdomain> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 09 Oct 2019 18:38:45 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, Laurent Vivier , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Oct 09, 2019 at 12:26:27PM -0400, Cleber Rosa wrote: > On Fri, Sep 27, 2019 at 11:37:52AM -0500, Eric Blake wrote: > > On 9/27/19 9:17 AM, Cleber Rosa wrote: > > > Due to not being able to find a reason to have shebangs on files that > > > are not executable. > > > > > > Signed-off-by: Cleber Rosa > > > --- > > > tests/qemu-iotests/common.config | 2 -- > > > tests/qemu-iotests/common.filter | 2 -- > > > tests/qemu-iotests/common.nbd | 1 - > > > tests/qemu-iotests/common.pattern | 2 -- > > > tests/qemu-iotests/common.qemu | 2 -- > > > tests/qemu-iotests/common.rc | 2 -- > > > tests/qemu-iotests/common.tls | 2 -- > > > 7 files changed, 13 deletions(-) > > > > > > > Loss of the shebang changes the mode in which emacs opens the files (from > > Shell-script[bash] to Conf[space] in my case). I agree that a #! comment is > > not appropriate for a file that is not executable as a standalone file, but > > it becomes harder to edit the file correctly unless we replace it with some > > other way of letting editors realize that the contents of each file is still > > meant to be consumed by bash. > > > > Something like this would work: > > > > # hey emacs, this file will be sourced by bash: -*- sh -*- > > > > Yes, good point. Will send that on a v2. > BTW, in addition to that, we may add to .editorconfig something like: [tests/qemu-iotests/common.*] indent_style = space indent_size = 4 file_type_emacs = sh Although I was expecting editorconfig to provide a mode hint for other editors, which doesn't seem to be the case. Cheers, - Cleber. > - Cleber. > > > -- > > Eric Blake, Principal Software Engineer > > Red Hat, Inc. +1-919-301-3226 > > Virtualization: qemu.org | libvirt.org