From: Wei Yang <richardw.yang@linux.intel.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, Wei Yang <richardw.yang@linux.intel.com>,
Peter Xu <peterx@redhat.com>,
quintela@redhat.com
Subject: Re: [PATCH 3/3] migration/postcopy: handle POSTCOPY_INCOMING_RUNNING corner case properly
Date: Thu, 10 Oct 2019 08:54:16 +0800 [thread overview]
Message-ID: <20191010005416.GA24524@richard> (raw)
In-Reply-To: <20191009090842.GD2893@work-vm>
On Wed, Oct 09, 2019 at 10:08:42AM +0100, Dr. David Alan Gilbert wrote:
>> >> >
>> >> >Maybe simply fix loadvm_postcopy_handle_run() to set the state after
>> >> >the POSTCOPY_INCOMING_LISTENING check?
>> >> >
>> >>
>> >> Set state back to ps if ps is not POSTCOPY_INCOMING_LISTENING?
>> >>
>> >> Sounds like another option.
>> >
>> >Even simpler?
>> >
>> > ps = postcopy_state_get();
>> > if (ps != INCOMING)
>
> ^^ LISTENING
>
oops
>> > return -1;
>> > postcopy_state_set(RUNNING);
>> >
>>
>> Looks good to me.
>>
>> Dave,
>>
>> Do you feel good with it?
>
>Yes, I think so; it's simpler.
>
I will prepare v2.
>Dave
>
>> >Thanks,
>> >
>> >--
>> >Peter Xu
>>
>> --
>> Wei Yang
>> Help you, Help me
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-10-10 0:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 10:01 [PATCH 0/3] migration/postcopy: cleanup related to postcopy Wei Yang
2019-10-01 10:01 ` [PATCH 1/3] migration/postcopy: rename postcopy_ram_enable_notify to postcopy_ram_incoming_setup Wei Yang
2019-10-08 14:17 ` Dr. David Alan Gilbert
2019-10-01 10:01 ` [PATCH 2/3] migration/postcopy: not necessary to do postcopy_ram_incoming_cleanup when state is ADVISE Wei Yang
2019-10-08 16:02 ` Dr. David Alan Gilbert
2019-10-09 0:55 ` Wei Yang
2019-10-09 9:03 ` Dr. David Alan Gilbert
2019-10-01 10:01 ` [PATCH 3/3] migration/postcopy: handle POSTCOPY_INCOMING_RUNNING corner case properly Wei Yang
2019-10-08 16:40 ` Dr. David Alan Gilbert
2019-10-09 1:02 ` Wei Yang
2019-10-09 4:12 ` Peter Xu
2019-10-09 5:07 ` Wei Yang
2019-10-09 5:36 ` Peter Xu
2019-10-09 6:07 ` Wei Yang
2019-10-09 9:08 ` Dr. David Alan Gilbert
2019-10-10 0:54 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010005416.GA24524@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).