From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Helge Deller" <deller@gmx.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Sven Schnelle" <svens@stackframe.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH 1/2] tests/boot_console: Send <carriage return> on serial lines
Date: Thu, 10 Oct 2019 14:21:27 +0200 [thread overview]
Message-ID: <20191010122128.29000-2-f4bug@amsat.org> (raw)
In-Reply-To: <20191010122128.29000-1-f4bug@amsat.org>
Some firmwares don't parse the <Newline> control character and
expect a <carriage return>.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/acceptance/boot_linux_console.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index 8a9a314ab4..f05452824e 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -51,7 +51,7 @@ class BootLinuxConsole(Test):
self.fail(fail)
def exec_command_and_wait_for_pattern(self, command, success_message):
- command += '\n'
+ command += '\r\n'
self.vm.console_socket.sendall(command.encode())
self.wait_for_console_pattern(success_message)
--
2.21.0
next prev parent reply other threads:[~2019-10-10 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 12:21 [PATCH 0/2] tests/acceptance: Add tests for the PA-RISC machine Philippe Mathieu-Daudé
2019-10-10 12:21 ` Philippe Mathieu-Daudé [this message]
2020-01-29 18:20 ` [PATCH 1/2] tests/boot_console: Send <carriage return> on serial lines Wainer dos Santos Moschetta
2019-10-10 12:21 ` [PATCH 2/2] tests/boot_console: Test booting HP-UX firmware upgrade Philippe Mathieu-Daudé
2020-01-29 18:28 ` Wainer dos Santos Moschetta
2019-10-18 14:23 ` [PATCH 0/2] tests/acceptance: Add tests for the PA-RISC machine Philippe Mathieu-Daudé
2019-10-18 14:40 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010122128.29000-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=crosa@redhat.com \
--cc=deller@gmx.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).