From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1289CC4360C for ; Thu, 10 Oct 2019 13:58:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA013208C3 for ; Thu, 10 Oct 2019 13:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA013208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIYxL-0008HG-SD for qemu-devel@archiver.kernel.org; Thu, 10 Oct 2019 09:58:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46909) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIYwi-0007kW-Qu for qemu-devel@nongnu.org; Thu, 10 Oct 2019 09:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIYwh-0004OV-ER for qemu-devel@nongnu.org; Thu, 10 Oct 2019 09:57:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58990) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIYwe-0004NX-AV; Thu, 10 Oct 2019 09:57:32 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 434418372F2; Thu, 10 Oct 2019 13:57:31 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80CE16012A; Thu, 10 Oct 2019 13:57:25 +0000 (UTC) Date: Thu, 10 Oct 2019 15:57:23 +0200 From: Igor Mammedov To: Guoheyi Subject: Re: [RFC PATCH 12/12] virt/acpi: add SDEI table if SDEI is enabled Message-ID: <20191010155723.24acb321@redhat.com> In-Reply-To: <3e889d37-b877-f7b5-7ee3-70cef6d8e9c1@huawei.com> References: <1569338511-3572-1-git-send-email-guoheyi@huawei.com> <1569338511-3572-13-git-send-email-guoheyi@huawei.com> <20191010111537.5e2dd584@redhat.com> <3e889d37-b877-f7b5-7ee3-70cef6d8e9c1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 10 Oct 2019 13:57:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Michael S. Tsirkin" , Marc Zyngier , qemu-devel@nongnu.org, Dave Martin , Shannon Zhao , qemu-arm@nongnu.org, James Morse , wanghaibin.wang@huawei.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 10 Oct 2019 21:08:10 +0800 Guoheyi wrote: > Thanks for your comments. > > On 2019/10/10 17:15, Igor Mammedov wrote: > > On Tue, 24 Sep 2019 23:21:51 +0800 > > Heyi Guo wrote: > > > >> Add SDEI table if SDEI is enabled, so that guest OS can get aware and > >> utilize the interfaces. > >> > >> Signed-off-by: Heyi Guo > >> Cc: Peter Maydell > >> Cc: Dave Martin > >> Cc: Marc Zyngier > >> Cc: Mark Rutland > >> Cc: James Morse > >> Cc: Shannon Zhao > >> Cc: "Michael S. Tsirkin" > >> Cc: Igor Mammedov > >> --- > >> hw/arm/virt-acpi-build.c | 16 ++++++++++++++++ > >> include/hw/acpi/acpi-defs.h | 5 +++++ > >> 2 files changed, 21 insertions(+) > >> > >> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > >> index 6cdf156..1088214 100644 > >> --- a/hw/arm/virt-acpi-build.c > >> +++ b/hw/arm/virt-acpi-build.c > >> @@ -32,6 +32,7 @@ > >> #include "trace.h" > >> #include "hw/core/cpu.h" > >> #include "target/arm/cpu.h" > >> +#include "target/arm/sdei.h" > >> #include "hw/acpi/acpi-defs.h" > >> #include "hw/acpi/acpi.h" > >> #include "hw/nvram/fw_cfg.h" > >> @@ -475,6 +476,16 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > >> } > >> > > here should be a comment describing purpose with a reference to spec > OK. > > > > >> static void > >> +build_sdei(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > >> +{ > >> + int sdei_start = table_data->len; > >> + > >> + (void)acpi_data_push(table_data, sizeof(AcpiSdei)); > >> + build_header(linker, table_data, (void *)(table_data->data + sdei_start), > >> + "SDEI", table_data->len - sdei_start, 1, NULL, NULL); > >> +} > > that's dummy table and doesn't match what spec describes, > > It doesn't look correct SDEI table. > > Refer to below document, Appendix C, I see the definition of SDEI is > really a dummy table, also it is said in the document: The table > consists only of a basic header with revision 1. > > http://infocenter.arm.com/help/topic/com.arm.doc.den0054a/ARM_DEN0054A_Software_Delegated_Exception_Interface.pdf > > Do I miss anything? No you are right and I was mistaken. It's pretty waste-full way to communicate to OS a Boolean flag that a new GHEST event is supported. But since they managed to make it a spec, it should be coded as such. > > > > >> + > >> +static void > >> build_spcr(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > >> { > >> AcpiSerialPortConsoleRedirection *spcr; > >> @@ -796,6 +807,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables) > >> acpi_add_table(table_offsets, tables_blob); > >> build_spcr(tables_blob, tables->linker, vms); > >> > >> + if (sdei_enabled) { > >> + acpi_add_table(table_offsets, tables_blob); > >> + build_sdei(tables_blob, tables->linker, vms); > >> + } > >> + > >> if (ms->numa_state->num_nodes > 0) { > >> acpi_add_table(table_offsets, tables_blob); > >> build_srat(tables_blob, tables->linker, vms); > >> diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > >> index 57a3f58..0a2265d 100644 > >> --- a/include/hw/acpi/acpi-defs.h > >> +++ b/include/hw/acpi/acpi-defs.h > >> @@ -634,4 +634,9 @@ struct AcpiIortRC { > >> } QEMU_PACKED; > >> typedef struct AcpiIortRC AcpiIortRC; > >> > >> +struct AcpiSdei { > >> + ACPI_TABLE_HEADER_DEF /* ACPI common table header */ > >> +} QEMU_PACKED; > >> +typedef struct AcpiSdei AcpiSdei; > > we don't use packed structures for ACPI anymore, see build_rsdp() for > > example of how tables are composed and comment style required for each field. > Sure; will fix it in v2. > > Thanks, > > Heyi > > > > >> #endif > > > > . > > > >