From: Wei Yang <richardw.yang@linux.intel.com>
To: Juan Quintela <quintela@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [Qemu-devel] [PULL 5/5] multifd: Use number of channels as listen backlog
Date: Fri, 11 Oct 2019 16:37:46 +0800 [thread overview]
Message-ID: <20191011083745.GA17297@richard> (raw)
In-Reply-To: <20190904062915.6488-6-quintela@redhat.com>
On Wed, Sep 04, 2019 at 08:29:15AM +0200, Juan Quintela wrote:
>Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>Signed-off-by: Juan Quintela <quintela@redhat.com>
>---
> migration/socket.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/migration/socket.c b/migration/socket.c
>index e63f5e1612..97c9efde59 100644
>--- a/migration/socket.c
>+++ b/migration/socket.c
>@@ -178,10 +178,15 @@ static void socket_start_incoming_migration(SocketAddress *saddr,
> {
> QIONetListener *listener = qio_net_listener_new();
> size_t i;
>+ int num = 1;
>
> qio_net_listener_set_name(listener, "migration-socket-listener");
>
>- if (qio_net_listener_open_sync(listener, saddr, 1, errp) < 0) {
>+ if (migrate_use_multifd()) {
>+ num = migrate_multifd_channels();
>+ }
>+
>+ if (qio_net_listener_open_sync(listener, saddr, num, errp) < 0) {
> object_unref(OBJECT(listener));
> return;
> }
My confusion is this function is called at the beginning of the program, which
means we didn't set multifd on or change the multifd channel parameter.
They are the default value at this point.
Am I right?
>--
>2.21.0
>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-10-11 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 6:29 [Qemu-devel] [PULL 0/5] Fail patches Juan Quintela
2019-09-04 6:29 ` [Qemu-devel] [PULL 1/5] socket: Add backlog parameter to socket_listen Juan Quintela
2019-09-04 6:29 ` [Qemu-devel] [PULL 2/5] socket: Add num connections to qio_channel_socket_sync() Juan Quintela
2019-09-04 6:29 ` [Qemu-devel] [PULL 3/5] socket: Add num connections to qio_channel_socket_async() Juan Quintela
2019-09-04 6:29 ` [Qemu-devel] [PULL 4/5] socket: Add num connections to qio_net_listener_open_sync() Juan Quintela
2019-09-04 6:29 ` [Qemu-devel] [PULL 5/5] multifd: Use number of channels as listen backlog Juan Quintela
2019-10-11 8:37 ` Wei Yang [this message]
2019-10-11 10:40 ` Juan Quintela
2019-10-11 12:15 ` Wei Yang
2019-09-04 15:29 ` [Qemu-devel] [PULL 0/5] Fail patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011083745.GA17297@richard \
--to=richardw.yang@linux.intel.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).