From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D6BECE58C for ; Fri, 11 Oct 2019 08:39:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32ADE2196E for ; Fri, 11 Oct 2019 08:39:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32ADE2196E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqSn-000092-BI for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 04:39:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqSB-0008BV-4h for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:39:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqSA-0001ve-1q for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:39:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:57309) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqS9-0001TY-PK; Fri, 11 Oct 2019 04:39:14 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 01:38:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,283,1566889200"; d="scan'208";a="188251420" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga008.jf.intel.com with ESMTP; 11 Oct 2019 01:38:02 -0700 Date: Fri, 11 Oct 2019 16:37:46 +0800 From: Wei Yang To: Juan Quintela Subject: Re: [Qemu-devel] [PULL 5/5] multifd: Use number of channels as listen backlog Message-ID: <20191011083745.GA17297@richard> References: <20190904062915.6488-1-quintela@redhat.com> <20190904062915.6488-6-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190904062915.6488-6-quintela@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: Fam Zheng , Kevin Wolf , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Michael Roth , qemu-block@nongnu.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Gerd Hoffmann , Paolo Bonzini , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Max Reitz , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 04, 2019 at 08:29:15AM +0200, Juan Quintela wrote: >Reviewed-by: Daniel P. Berrangé >Signed-off-by: Juan Quintela >--- > migration/socket.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/migration/socket.c b/migration/socket.c >index e63f5e1612..97c9efde59 100644 >--- a/migration/socket.c >+++ b/migration/socket.c >@@ -178,10 +178,15 @@ static void socket_start_incoming_migration(SocketAddress *saddr, > { > QIONetListener *listener = qio_net_listener_new(); > size_t i; >+ int num = 1; > > qio_net_listener_set_name(listener, "migration-socket-listener"); > >- if (qio_net_listener_open_sync(listener, saddr, 1, errp) < 0) { >+ if (migrate_use_multifd()) { >+ num = migrate_multifd_channels(); >+ } >+ >+ if (qio_net_listener_open_sync(listener, saddr, num, errp) < 0) { > object_unref(OBJECT(listener)); > return; > } My confusion is this function is called at the beginning of the program, which means we didn't set multifd on or change the multifd channel parameter. They are the default value at this point. Am I right? >-- >2.21.0 > -- Wei Yang Help you, Help me