From: Kevin Wolf <kwolf@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files
Date: Fri, 11 Oct 2019 11:36:10 +0200 [thread overview]
Message-ID: <20191011093610.GD5158@localhost.localdomain> (raw)
In-Reply-To: <20191009194740.8079-2-crosa@redhat.com>
Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben:
> Due to not being able to find a reason to have shebangs on files that
> are not executable.
>
> While at it, add a mode hint to emacs, which would be clueless or
> plain wrong about these containing shell code.
vim still doesn't like the change.
Of course, we could also add another line for vim and for every other
editor in use, but actually, I think I'd prefer just dropping this
patch. It even makes each file a few bytes larger instead of saving
something. Shebang lines are a shorter and more portable format
indicator than the alternatives.
So I think in the end we have found a good reason to keep them. :-)
Kevin
next prev parent reply other threads:[~2019-10-11 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 19:47 [PATCH v2 0/4] iotests: trivial cleanups Cleber Rosa
2019-10-09 19:47 ` [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files Cleber Rosa
2019-10-09 19:51 ` Eric Blake
2019-10-09 20:54 ` Cleber Rosa
2019-10-11 9:36 ` Kevin Wolf [this message]
2019-10-11 11:27 ` Nir Soffer
2019-10-11 20:05 ` Cleber Rosa
2019-10-11 20:30 ` Kevin Wolf
2019-10-09 19:47 ` [PATCH v2 2/4] qemu-iotests: remove forceful execution success " Cleber Rosa
2019-10-11 11:25 ` Kevin Wolf
2019-10-09 19:47 ` [PATCH v2 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Cleber Rosa
2019-10-10 11:27 ` Philippe Mathieu-Daudé
2019-10-11 11:26 ` Kevin Wolf
2019-10-09 19:47 ` [PATCH v2 4/4] qemu-iotests: 044: remove inaccurate docstring class description Cleber Rosa
2019-10-11 11:27 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011093610.GD5158@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=crosa@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).