From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A94AECE58C for ; Fri, 11 Oct 2019 13:33:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D32A2084C for ; Fri, 11 Oct 2019 13:33:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D32A2084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIv2S-0000Bl-HY for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 09:33:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36418) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIv1p-0008Du-2E for qemu-devel@nongnu.org; Fri, 11 Oct 2019 09:32:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIv1o-0003vz-0u for qemu-devel@nongnu.org; Fri, 11 Oct 2019 09:32:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40712) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIv1n-0003vl-Rq for qemu-devel@nongnu.org; Fri, 11 Oct 2019 09:32:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D9D810C0515; Fri, 11 Oct 2019 13:32:19 +0000 (UTC) Received: from work-vm (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 168765D9CA; Fri, 11 Oct 2019 13:32:17 +0000 (UTC) Date: Fri, 11 Oct 2019 14:32:15 +0100 From: "Dr. David Alan Gilbert" To: Wei Yang Subject: Re: [PATCH 0/4] migration: trivial cleanup and refine Message-ID: <20191011133215.GE18007@work-vm> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191005220517.24029-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Fri, 11 Oct 2019 13:32:19 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Wei Yang (richardw.yang@linux.intel.com) wrote: > This patch set contains several cleanup and refine for migration. > > simplify some calculation > reuse the result > fix typo in comment > provide error message when failed 2,3,4 queued > > Wei Yang (4): > migration/ram: only possible bit set in invalid_flags is > RAM_SAVE_FLAG_COMPRESS_PAGE > migration/postcopy: fix typo in mark_postcopy_blocktime_begin's > comment > migration: pass in_postcopy instead of check state again > migration: report SaveStateEntry id and name on failure > > migration/migration.c | 3 +-- > migration/postcopy-ram.c | 8 +++++--- > migration/ram.c | 5 +---- > migration/savevm.c | 2 ++ > 4 files changed, 9 insertions(+), 9 deletions(-) > > -- > 2.17.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK