From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDA4C47404 for ; Fri, 11 Oct 2019 20:07:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DAFD214E0 for ; Fri, 11 Oct 2019 20:07:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DAFD214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJ1Bw-00042n-80 for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 16:07:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44315) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJ1A3-0002Yu-LW for qemu-devel@nongnu.org; Fri, 11 Oct 2019 16:05:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJ1A2-0001Pq-N6 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 16:05:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41398) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iJ19y-0001HW-Qc; Fri, 11 Oct 2019 16:05:10 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40E802D1EF1; Fri, 11 Oct 2019 20:05:08 +0000 (UTC) Received: from dhcp-17-179.bos.redhat.com (dhcp-17-179.bos.redhat.com [10.18.17.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD140A7D0; Fri, 11 Oct 2019 20:05:02 +0000 (UTC) Date: Fri, 11 Oct 2019 16:05:01 -0400 From: Cleber Rosa To: Nir Soffer Subject: Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files Message-ID: <20191011200501.GA18783@dhcp-17-179.bos.redhat.com> References: <20191009194740.8079-1-crosa@redhat.com> <20191009194740.8079-2-crosa@redhat.com> <20191011093610.GD5158@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 11 Oct 2019 20:05:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block , qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, Laurent Vivier , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Oct 11, 2019 at 02:27:25PM +0300, Nir Soffer wrote: > On Fri, Oct 11, 2019, 12:36 Kevin Wolf wrote: > > > Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben: > > > Due to not being able to find a reason to have shebangs on files that > > > are not executable. > > > > > > While at it, add a mode hint to emacs, which would be clueless or > > > plain wrong about these containing shell code. > > > > vim still doesn't like the change. > > > > Of course, we could also add another line for vim and for every other > > editor in use, but actually, I think I'd prefer just dropping this > > patch. It even makes each file a few bytes larger instead of saving > > something. Shebang lines are a shorter and more portable format > > indicator than the alternatives. > > > > So I think in the end we have found a good reason to keep them. :-) > > > > What about .sh suffix? Should be most portable way. > > > That's the approach I tend to follow for my sh code. Explicit is better than implicit if you ask me. Kevin, Do you have any strong feelings here? I'd be fine with either this or dropping the patch. Thanks, - Cleber.