From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH 1/4] vl: Split off user_creatable_print_help()
Date: Mon, 14 Oct 2019 11:55:25 +0200 [thread overview]
Message-ID: <20191014095525.GC7173@localhost.localdomain> (raw)
In-Reply-To: <f1b7efeb-6ce5-2943-76fc-12b6d0f09215@redhat.com>
Am 11.10.2019 um 23:35 hat Eric Blake geschrieben:
> On 10/11/19 3:55 PM, Kevin Wolf wrote:
> > Printing help for --object is something that we don't only want in the
>
> s/don't/not/
Can someone send a fix for the English grammar? It's obviously broken
and doesn't know what it wants. Actually, maybe do-support was a bad
idea and we should just revert it and restore consistent use of proper
verb-second word order?
(Hm, actually, since this seems to negate "only" rather than the verb,
does "...that we want not only in..." work without patching the
grammar?)
(Thanks for the correction.)
Kevin
> > system emulator, but also in tools that support --object. Move it into a
> > separate function in qom/object_interfaces.c to make the code accessible
> > for tools.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2019-10-14 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 20:55 [PATCH 0/4] qemu-img/io/nbd: Support help options for --object Kevin Wolf
2019-10-11 20:55 ` [PATCH 1/4] vl: Split off user_creatable_print_help() Kevin Wolf
2019-10-11 21:35 ` Eric Blake
2019-10-14 9:55 ` Kevin Wolf [this message]
2019-10-14 14:18 ` Eric Blake
2019-10-11 20:55 ` [PATCH 2/4] qemu-io: Support help options for --object Kevin Wolf
2019-10-11 21:36 ` Eric Blake
2019-10-11 20:55 ` [PATCH 3/4] qemu-img: " Kevin Wolf
2019-10-11 21:37 ` Eric Blake
2019-10-11 20:55 ` [PATCH 4/4] qemu-nbd: " Kevin Wolf
2019-10-11 21:39 ` Eric Blake
2019-10-14 9:47 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014095525.GC7173@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).