From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Nir Soffer <nsoffer@redhat.com>,
Anton Nefedov <anton.nefedov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK
Date: Mon, 14 Oct 2019 16:21:27 +0200 [thread overview]
Message-ID: <20191014142127.GH7173@localhost.localdomain> (raw)
In-Reply-To: <w5136fvtvug.fsf@maestria.local.igalia.com>
Am 14.10.2019 um 13:22 hat Alberto Garcia geschrieben:
> On Mon 14 Oct 2019 11:26:01 AM CEST, Kevin Wolf wrote:
> >> Signed-off-by: Alberto Garcia <berto@igalia.com>
> >
> > Thanks, applied to the block branch.
>
> I'm a bit late now, but a possible trivial optimization is to flip the
> conditions, because checking the flag should be faster than checking the
> alignment and it's going to be false in almost all cases:
>
> if ((flags & BDRV_REQ_NO_FALLBACK) &&
> !QEMU_IS_ALIGNED(offset | bytes, align)) {
> return -ENOTSUP;
> }
>
> Feel free to edit the commit if you want.
Ok, I'll update it.
Kevin
prev parent reply other threads:[~2019-10-14 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 8:15 [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK Alberto Garcia
2019-10-14 8:41 ` no-reply
2019-10-14 9:26 ` Kevin Wolf
2019-10-14 11:22 ` Alberto Garcia
2019-10-14 14:21 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014142127.GH7173@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).