From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py
Date: Wed, 16 Oct 2019 15:05:37 +0200 [thread overview]
Message-ID: <20191016130537.GB4940@localhost.localdomain> (raw)
In-Reply-To: <20191001191514.11208-7-armbru@redhat.com>
Am 01.10.2019 um 21:15 hat Markus Armbruster geschrieben:
> The QAPI code generator clocks in at some 3100 SLOC in 8 source files.
> Almost 60% of the code is in qapi/common.py. Split it into more
> focused modules:
>
> * Move QAPISchemaPragma and QAPISourceInfo to qapi/source.py.
>
> * Move QAPIError and its sub-classes to qapi/error.py.
>
> * Move QAPISchemaParser and QAPIDoc to parser.py. Use the opportunity
> to put QAPISchemaParser first.
>
> * Move check_expr() & friends to qapi/expr.py. Use the opportunity to
> put the code into a more sensible order.
>
> * Move QAPISchema & friends to qapi/schema.py
>
> * Move QAPIGen and its sub-classes, ifcontext,
> QAPISchemaModularCVisitor, and QAPISchemaModularCVisitor to qapi/gen.py
>
> A number of helper functions remain in qapi/common.py. I considered
> moving the code generator helpers to qapi/gen.py, but decided not to.
> Perhaps we should rewrite them as methods of QAPIGen some day.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
This patch seems to forget to change qapi-py in the Makefile, so that
when you change one of the new source files, the generator won't run
again.
Kevin
next prev parent reply other threads:[~2019-10-16 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 19:15 [PATCH 0/7] qapi: Cleanups and test speedup Markus Armbruster
2019-10-01 19:15 ` [PATCH 1/7] qapi: Don't suppress doc generation without pragma doc-required Markus Armbruster
2019-10-01 19:59 ` Eric Blake
2019-10-01 19:15 ` [PATCH 2/7] qapi: Store pragma state in QAPISourceInfo, not global state Markus Armbruster
2019-10-01 20:01 ` Eric Blake
2019-10-01 19:15 ` [PATCH 3/7] qapi: Eliminate accidental global frontend state Markus Armbruster
2019-10-01 20:03 ` Eric Blake
2019-10-01 19:15 ` [PATCH 4/7] qapi: Speed up frontend tests Markus Armbruster
2019-10-01 20:23 ` Eric Blake
2019-10-02 14:31 ` Markus Armbruster
2019-10-01 19:15 ` [PATCH 5/7] qapi: Move gen_enum(), gen_enum_lookup() back to qapi/types.py Markus Armbruster
2019-10-01 20:26 ` Eric Blake
2019-10-01 19:15 ` [PATCH 6/7] qapi: Split up scripts/qapi/common.py Markus Armbruster
2019-10-01 21:19 ` Eric Blake
2019-10-02 15:16 ` Markus Armbruster
2019-10-02 15:27 ` Eric Blake
2019-10-02 16:13 ` Markus Armbruster
2019-10-16 13:05 ` Kevin Wolf [this message]
2019-10-16 14:09 ` Markus Armbruster
2019-10-01 19:15 ` [PATCH 7/7] qapi: Clear scripts/qapi/doc.py executable bits again Markus Armbruster
2019-10-01 20:34 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016130537.GB4940@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).