From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org
Subject: [PATCH 07/10] image-fuzzer: Use bytes constant for field values
Date: Wed, 16 Oct 2019 16:24:27 -0300 [thread overview]
Message-ID: <20191016192430.25098-8-ehabkost@redhat.com> (raw)
In-Reply-To: <20191016192430.25098-1-ehabkost@redhat.com>
Field values are supposed to be bytes objects, not unicode
strings. Change two constants that were declared as strings.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/image-fuzzer/qcow2/layout.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py
index 0adcbd448d..a0fd53c7ad 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -122,7 +122,7 @@ class Image(object):
def create_header(self, cluster_bits, backing_file_name=None):
"""Generate a random valid header."""
meta_header = [
- ['>4s', 0, "QFI\xfb", 'magic'],
+ ['>4s', 0, b"QFI\xfb", 'magic'],
['>I', 4, random.randint(2, 3), 'version'],
['>Q', 8, 0, 'backing_file_offset'],
['>I', 16, 0, 'backing_file_size'],
@@ -231,7 +231,7 @@ class Image(object):
feature_tables = []
feature_ids = []
inner_offset = self.ext_offset + ext_header_len
- feat_name = 'some cool feature'
+ feat_name = b'some cool feature'
while len(feature_tables) < num_fnt_entries * 3:
feat_type, feat_bit = gen_feat_ids()
# Remove duplicates
--
2.21.0
next prev parent reply other threads:[~2019-10-16 19:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 19:24 [PATCH 00/10] image-fuzzer: Port to Python 3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 01/10] image-fuzzer: Open image files in binary mode Eduardo Habkost
2019-10-17 9:55 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file Eduardo Habkost
2019-10-17 9:56 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 03/10] image-fuzzer: Explicitly use integer division operator Eduardo Habkost
2019-10-16 19:24 ` [PATCH 04/10] image-fuzzer: Use io.StringIO Eduardo Habkost
2019-10-16 19:24 ` [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__() Eduardo Habkost
2019-10-17 21:08 ` John Snow
2019-10-16 19:24 ` [PATCH 06/10] image-fuzzer: Return bytes objects on string fuzzing functions Eduardo Habkost
2019-10-16 19:24 ` Eduardo Habkost [this message]
2019-10-17 9:55 ` [PATCH 07/10] image-fuzzer: Use bytes constant for field values Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 08/10] image-fuzzer: Encode file name and file format to bytes Eduardo Habkost
2019-10-16 19:24 ` [PATCH 09/10] image-fuzzer: Run using python3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 10/10] image-fuzzer: Use errors parameter of subprocess.Popen() Eduardo Habkost
2019-10-17 21:11 ` [PATCH 00/10] image-fuzzer: Port to Python 3 John Snow
2019-10-17 21:29 ` Eduardo Habkost
2019-10-17 22:41 ` John Snow
2019-10-22 20:26 ` Eduardo Habkost
2019-10-23 15:42 ` John Snow
2019-11-05 15:35 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016192430.25098-8-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).