* Re: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
2019-10-17 0:46 [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE) Wei Yang
@ 2019-10-17 2:32 ` no-reply
2019-10-17 4:59 ` Richard Henderson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: no-reply @ 2019-10-17 2:32 UTC (permalink / raw)
To: richardw.yang
Cc: thuth, berrange, richard.henderson, qemu-devel, richardw.yang,
stefanha, pbonzini, philmd
Patchew URL: https://patchew.org/QEMU/20191017004633.13229-1-richardw.yang@linux.intel.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
Type: series
Message-id: 20191017004633.13229-1-richardw.yang@linux.intel.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3751d76 checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#22: FILE: scripts/checkpatch.pl:2919:
+ ERROR("use qemu_real_host_page_size instead of getpagesize()\n" . $herecurr);
ERROR: line over 90 characters
#25: FILE: scripts/checkpatch.pl:2922:
+ ERROR("use qemu_real_host_page_size instead of sysconf(_SC_PAGESIZE)\n" . $herecurr);
total: 2 errors, 0 warnings, 12 lines checked
Commit 3751d7633653 (checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191017004633.13229-1-richardw.yang@linux.intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
2019-10-17 0:46 [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE) Wei Yang
2019-10-17 2:32 ` no-reply
@ 2019-10-17 4:59 ` Richard Henderson
2019-10-17 9:40 ` Stefan Hajnoczi
2019-10-22 7:45 ` Paolo Bonzini
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2019-10-17 4:59 UTC (permalink / raw)
To: Wei Yang, pbonzini, philmd, eblake, thuth, berrange
Cc: qemu-devel, Stefan Hajnoczi
On 10/16/19 5:46 PM, Wei Yang wrote:
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> CC: Richard Henderson <richard.henderson@linaro.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
>
> ---
> v2: add "\b" for better match, suggested by Richard Henderson <richard.henderson@linaro.org>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
2019-10-17 0:46 [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE) Wei Yang
2019-10-17 2:32 ` no-reply
2019-10-17 4:59 ` Richard Henderson
@ 2019-10-17 9:40 ` Stefan Hajnoczi
2019-10-22 7:45 ` Paolo Bonzini
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2019-10-17 9:40 UTC (permalink / raw)
To: Wei Yang; +Cc: thuth, berrange, Richard Henderson, qemu-devel, pbonzini, philmd
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Thu, Oct 17, 2019 at 08:46:33AM +0800, Wei Yang wrote:
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> CC: Richard Henderson <richard.henderson@linaro.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
>
> ---
> v2: add "\b" for better match, suggested by Richard Henderson <richard.henderson@linaro.org>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
2019-10-17 0:46 [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE) Wei Yang
` (2 preceding siblings ...)
2019-10-17 9:40 ` Stefan Hajnoczi
@ 2019-10-22 7:45 ` Paolo Bonzini
3 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2019-10-22 7:45 UTC (permalink / raw)
To: Wei Yang, philmd, eblake, thuth, berrange
Cc: Richard Henderson, qemu-devel, Stefan Hajnoczi
On 17/10/19 02:46, Wei Yang wrote:
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> CC: Richard Henderson <richard.henderson@linaro.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
>
> ---
> v2: add "\b" for better match, suggested by Richard Henderson <richard.henderson@linaro.org>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index aa9a354a0e..ab68a16fd2 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2915,6 +2915,12 @@ sub process {
> if ($line =~ /\bbzero\(/) {
> ERROR("use memset() instead of bzero()\n" . $herecurr);
> }
> + if ($line =~ /\bgetpagesize\(\)/) {
> + ERROR("use qemu_real_host_page_size instead of getpagesize()\n" . $herecurr);
> + }
> + if ($line =~ /\bsysconf\(_SC_PAGESIZE\)/) {
> + ERROR("use qemu_real_host_page_size instead of sysconf(_SC_PAGESIZE)\n" . $herecurr);
> + }
> my $non_exit_glib_asserts = qr{g_assert_cmpstr|
> g_assert_cmpint|
> g_assert_cmpuint|
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread