From: Stefan Hajnoczi <stefanha@redhat.com>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: virtio-fs@redhat.com, mszeredi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation
Date: Thu, 17 Oct 2019 11:05:28 +0100 [thread overview]
Message-ID: <20191017100528.GA24790@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191016103754.2047-1-misono.tomohiro@jp.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]
On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote:
> Hello,
>
> I test xattr operation on virtiofs using xfstest generic/062
> (with -o xattr option and XFS backend) and see some problems.
>
> These patches fixes the two of the problems.
>
> The remaining problems are:
> 1. we cannot xattr to block device created by mknod
> which does not have actual device (since open in virtiofsd fails)
> 2. we cannot xattr to symbolic link
>
> I don't think 1 is a big problem but can we fix 2?
Sorry, I don't know the answer. Maybe it would be necessary to add a
new O_SYMLINK open flag to open(2) so that fgetxattr()/fsetxattr()
operations can be performed. A kernel change like that would take some
time to get accepted upstream and shipped by distros, but it might be
the only way since the current syscall interface doesn't seem to offer a
way to do this.
>
> Misono Tomohiro (2):
> virtiofsd: Avoid process hang when doing xattr operation to FIFO
> virtiofsd: Allow setxattr operation to directry
>
> contrib/virtiofsd/passthrough_ll.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.21.0
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-17 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:37 [PATCH 0/2] virtiofsd: Two fix for xattr operation Misono Tomohiro
2019-10-16 10:37 ` [PATCH 1/2] virtiofsd: Avoid process hang when doing xattr operation to FIFO Misono Tomohiro
2019-10-16 10:37 ` [PATCH 2/2] virtiofsd: Allow setxattr operation to directry Misono Tomohiro
2019-10-17 10:05 ` Stefan Hajnoczi [this message]
2019-10-17 11:23 ` [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation Miklos Szeredi
2019-10-17 13:01 ` Miklos Szeredi
2019-10-17 15:25 ` Vivek Goyal
2019-10-17 15:45 ` Miklos Szeredi
2019-10-17 16:09 ` Stefan Hajnoczi
2019-10-17 16:48 ` Miklos Szeredi
2019-10-18 7:16 ` Miklos Szeredi
2019-10-18 8:51 ` misono.tomohiro
2019-10-21 9:40 ` Stefan Hajnoczi
2019-10-23 11:42 ` misono.tomohiro
2019-10-25 12:54 ` Stefan Hajnoczi
2019-10-18 10:09 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017100528.GA24790@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=mszeredi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).